bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] maint: remove useless REPLACE_*_H macros


From: Bruno Haible
Subject: Re: [PATCH 1/2] maint: remove useless REPLACE_*_H macros
Date: Thu, 5 May 2011 11:20:07 +0200
User-agent: KMail/1.9.9

Hi Eric,

> There are still a few modules, like iconv_h.m4, that still
> use older paradigms where GNULIB_POSIXCHECK is unsupported
> and where gl_REPLACE_<HEADER>_H is still essential.  But since
> we are moving away from that style, I see no reason to keep
> the idiom for the modules that don't need it.

I agree. Replacing the headers unconditionally is stable enough by now.
It's unlikely that we will switch back to the older idiom.

This patch 1/2 is fine.

PATCH 2/2 looks wrong, though. More on this in a separate mail.

Bruno
-- 
In memoriam Peter van Pels <http://en.wikipedia.org/wiki/Peter_van_Pels>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]