[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] test-fclose: avoid over-specification (leading to abort)
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] test-fclose: avoid over-specification (leading to abort) |
|
Date: |
Thu, 12 May 2011 08:55:01 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 05/12/2011 08:52 AM, Jim Meyering wrote:
> Hi Eric,
>
> This test would fail for me when I made iwhd use the latest from gnulib:
>
> FAIL: test-fclose (exit: 134)
> =============================
> test-fclose.c:77: assertion failed
>
> It looks pretty obvious, but I'll wait for your ACK, just in case.
NACK.
The whole point of this test is to expose the glibc bug.
fclose() is _required_ to rewind seekable input streams back to the
point of the last byte returned by fgetc(). That is, even though
fgetc() advanced the position to EOF, the fclose() must undo that advance.
More likely, this means all the recent flurry in lib/fclose.c has
somehow introduced a regression :(
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature