Re: [PATCH] maint.mk: add a syntax-check rule to ensure tightly-scoped symbols

[Pádraig Brady]

On 09/05/11 11:44, Jim Meyering wrote:
> I've been using a precursor of this rule in coreutils for many years,

> so finally have made it general enough so that the same

The above change is giving a false positive on my 32 linux laptop,
where it flags  __i686.get_pc_thunk.bx from src/libstdbuf_so-libstdbuf.o
The following fix auto excludes any symbols starting with an underscore.
Maybe I should do this only for double underscores?

pb-laptop:~/git/coreutils$ diff gnulib/top/maint.mk maint.mk
--- gnulib/top/maint.mk 2011-05-14 09:30:58.000000000 +0000
+++ maint.mk    2011-05-17 12:45:56.000000000 +0000
@@ -1397,7 +1397,7 @@
          perl -lne '$(_gl_TS_function_match)'                          \
                  -e 'and print $$1' $$hdr;                             \
        ) | sort -u | sed 's/^/^/;s/$$/$$/' > $$t;                      \
-       nm -e *.$(OBJEXT) | sed -n 's/.* T //p' | grep -Ev -f $$t       \
+       nm -e *.$(OBJEXT) | sed -n 's/.* T \([^_]\)/\1/p' | grep -Ev -f $$t \
          && { echo the above functions should have static scope >&2;   \
               exit 1; } || : ;                                         \
        ( printf '^%s$$\n' $(_gl_TS_unmarked_extern_vars);              \