[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: circular dependency [was: perror bug]
From: |
Eric Blake |
Subject: |
Re: circular dependency [was: perror bug] |
Date: |
Fri, 20 May 2011 13:05:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 05/20/2011 12:42 PM, Bruno Haible wrote:
> Hi Eric,
>
>> This change means that now strerror depends on strerror_r-posix, and
>> strerror_r-posix depends on strerror. Is that circular dependency okay
>> for gnulib-tool?
>
> Yes, gnulib-tool supports circular dependencies, even with
> --conditional-dependencies.
>
> But the circular dependency was not intended. Fixing it:
Oh my. This makes my recent test-perror2 fail on FreeBSD, because it
tests that perror and strerror match (as per POSIX), rather than
strerror_r, but our perror replacement kicks in even when the strerror
replacement does not. I'm debating if there is a better way to fix
this, but am pushing this as the minimal fix for now:
diff --git i/modules/perror-tests w/modules/perror-tests
index 9a6ba47..3770d77 100644
--- i/modules/perror-tests
+++ w/modules/perror-tests
@@ -7,6 +7,7 @@ tests/test-perror2.c
tests/test-perror.sh
Depends-on:
+strerror
configure.ac:
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature