Re: [PATCH 0/348] move AC_LIBOBJ invocations to the module descriptions

[Eric Blake]

On 06/06/2011 04:29 PM, Bruno Haible wrote:
> Hi all,
> 
> In <http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00174.html> we
> found out that every AC_LIBOBJ invocation must be triggered from a module
> that contains the referred file. Otherwise bugs occur.
> 
> The most straightforward and safe way to ensure this is to more the AC_LIBOBJ
> invocations to the module descriptions. Additionally, this clarifies which
> files get compiled and under which conditions.
> 
> Here is a series of proposed patches to gnulib that implement this for most
> *.m4 files. It consists of
> 
>   - 260 changes of conditional AC_LIBOBJ invocations, and - where necessary -
>     an adjustment between the AC_LIBOBJ condition and the condition listed
>     in the 'Depends-on' section.
> 
>     This series fixes 30 bugs (marked "Respect rules for use of AC_LIBOBJ" in
>     the respective ChangeLog entry).
> 
>   - 88 changes of unconditional AC_LIBOBJ invocations. Here I had the choice
>     among just moving the AC_LIBOBJ to the configure.ac section and replacing
>     it with an augmentation of lib_SOURCES. I chose the second option
>     because it's more declarative and integrates better with Automake (allows
>     use of Automake conditionals).
> 
>     This series fixes 2 bugs.
> 
> Please review and comment. I'll wait for objections for a week.

No objections from me, but I haven't thoroughly reviewed anything yet
(at any rate, I _have_ applied all the patches into my tree, so I can at
least try it out in a few projects in the next few days).

Meanwhile, I'm accelerating your perror and strerror fixes (I got cygwin
1.7.9 strerror_r working only by using those patches); more in another
thread.

> 2011-05-22  Bruno Haible  <address@hidden>
> 
>       strerror: Move AC_LIBOBJ invocations to module description.
>       * m4/strerror.m4 (gl_FUNC_STRERROR): Move AC_LIBOBJ and
>       gl_PREREQ_STRERROR invocations from here...
>       * modules/strerror (configure.ac): ... to here.
> 

> 2011-05-21  Bruno Haible  <address@hidden>
> 
>       perror: Use common idiom.
>       * modules/perror (configure.ac): Reorder statements.
> 

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature