Re: [PATCH] snprintf: guarantee %1$d, for libintl

[Bruno Haible]

Hi Eric,

> diff --git a/ChangeLog b/ChangeLog
> index fcc2e6e..5f3ffb7 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,13 @@
> +2011-07-01  Eric Blake  <address@hidden>
> +
> +     snprintf: guarantee %1$d, for libintl
> +     * m4/snprintf.m4 (gl_FUNC_SNPRINTF): Require %1$d support.
> +     * m4/vsnprintf.m4 (gl_FUNC_VSNPRINTF): Likewise.
> +     * doc/posix-functions/snprintf.texi (snprintf): Update.
> +     * doc/posix-functions/vsnprintf.texi (vsnprintf): Likewise.
> +     * tests/test-snprintf.c (main): Enhance test.
> +     * tests/test-vsnprintf.c (main): Likewise.

This patch is all right.

I knew it was risky to provide an snprintf replacement in libintl that fixes
the %n$ interpretation but not the return value, and on the other hand gnulib
also may or may not replace snprintf... Thanks for all the analysis.

The changes warrant some comments, but we can add them later. I'm too tired for
today.

Bruno
-- 
In memoriam Yuri Shchekochikhin 
<http://en.wikipedia.org/wiki/Yuri_Shchekochikhin>