[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] largefile: add dependencies to this module
|
From: |
Paul Eggert |
|
Subject: |
Re: [PATCH] largefile: add dependencies to this module |
|
Date: |
Sun, 24 Jul 2011 23:46:12 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 |
On 07/24/11 13:27, Bruno Haible wrote:
> I don't see the reasoning for adding the dependency to modules
> like 'acl', 'javacomp' and 'same'.
I'll address these examples below.
> If you are adding a dependency to these modules, it sounds like
> every piece of application code that somehow deads with files
> via <unistd.h> or <sys/stat.h> would need a dependency to
> 'largefile'?
That's too strong. The key point is that code invoking primitives
like 'stat', 'fstat', and 'open', where the runtime behavior differs
depending on whether large files are enabled, should use the largefile
module. That's pretty much the analysis you did.
Some of these primitives, such as 'fstat', do not correspond to any
gnulib modules, and so we need to depend directly on largefile (or add
a dummy module, though that sounds less desirable). Some, such as
'stat', are often not listed as dependencies, perhaps because they
were missed or perhaps because their other bugs are not important; in
any case, 'stat' might be avoided so a module that uses the 'stat'
function still needs to depend directly on largefile (this is in line
with the general principle that modules should list all dependencies
that are locally determinable). And some primitives are pretty
obscure and are not necessarily listed in POSIX (fsusage.c uses them,
for example), so a direct dependency on largefile makes sense for them.
Let's look at the agreements and disagreements between our analyses.
* Modules where we already agreed: fseeko, openat, ftello, lseek,
mkstemp, pwrite.
* In your list but not mine:
. You're right about freopen, fseek, ftell, scandir, tmpfile, mkostemp,
mkostemps, mkstemps; I missed those.
. You're also right about fopen, glob, lstat, open, pread, stat.
These modules I made dependent on largefile only if they were
replaced, but they should depend unconditionally.
. alphasort works regardless of whether largefile is in effect,
since it merely manipulates struct stat values; it doesn't
actually fetch them from the file system. So it doesn't need to
depend on largefile.
* In my list but not yours:
. acl has lib/copy-acl.c, which invokes 'stat'. Perhaps acl
should depend on the 'stat' module, but it doesn't. Also,
suppose the 'stat' module is avoided? largefile should still
be used.
. canonicalize has lib/canonicalize.c, which invokes 'lstat'.
canonicalize does depend on the 'lstat' module, but we still
have a problem if the lstat module is avoided.
. chdir-safer has lib/chdir-safer.c, which invokes fstat and lstat.
It does not depend on 'lstat'. Perhaps it should, but lstat
could be avoided. And suppose it stops using lstat but continues
to use fstat? There is no fstat module, so it needs to depend on
largefile directly.
. copy-file has lib/copy-file.c, which invokes fstat.
. fileblocks has lib/fileblocks.c, which uses low-level system
macros and types such as daddr_t that probably depend on largefile.
. fsusage has lib/fsusage.c, which is like fileblocks.c on steroids.
. ftruncate (which is obsolete) uses low-level fcntls that may well
depend on largefile.
. fts has lib/fts.c which invokes fstat.
. isdir has lib/isdir.c which invokes stat, and the stat module might
be avoided.
. javacomp has lib/javacomp.c, which invokes 'stat', which might be avoided.
. mkdir-p has lib/midr-p.c, which invokes 'stat', which might be avoided.
. modechange has lib/modechange.c, which invokes 'stat', which might be
avoided.
. mountlist invokes lots of low-level things like getfsstat that might
depend on largefile. It also invokes stat, which might be avoided.
. pt_chown has lib/pt_chown.c, which invokes 'stat', which might be avoided.
. read-file has lib/read-file.c, which invokes fstat.
. relocatable-prog and relocatable-prog-wrapper have
lib/relocatable.c, which invokes 'fstat and 'stat'. It doesn't
currently depend on 'stat', but 'stat' might be avoided.
. same has lib/same.c, which invokes 'stat', which might be avoided.
. tempname has lib/tempname.c, which invokes 'lstat', which might be avoided.
. tmpdir has lib/tmpdir.c, which invokes 'lstat', which is not listed as
a dependency and which might be avoided.
. unlink has lib/unlink.c, which invokes 'lstat', which might be avoided.
. utimecmp has lib/utimecmp.c, which invokes 'lstat' and 'stat'. The
former is listed as a dependency but might be avoided, and the latter
is not listed.
. utimens has lib/utimens.c, which invokes fstat, lstat and stat.
Only lstat is listed as a dependency, and it might be avoided.
With the above in mind, here's a revised proposed patch.
>From 442d95175bd21dd16cf38a9988bde57f2ca158a8 Mon Sep 17 00:00:00 2001
From: Paul Eggert <address@hidden>
Date: Sun, 24 Jul 2011 00:54:21 -0700
Subject: [PATCH] largefile: add dependencies to this module
* m4/mkstemp.m4 (gl_FUNC_MKSTEMP):
* m4/tempname.m4 (gl_FUNC_GEN_TEMPNAME):
Do not require AC_SYS_LARGEFILE, since the containing module now
depends on the largefile module.
* modules/acl, modules/canonicalize, modules/canonicalize-lgpl:
* modules/chdir-safer, modules/chown, modules/copy-file:
* modules/euidaccess, modules/fchdir, modules/fdopendir:
* modules/fflush, modules/fileblocks, modules/fopen, modules/freopen:
* modules/fseek, modules/fseeko, modules/fsusage, modules/ftell:
* modules/ftello, modules/ftruncate, modules/fts, modules/getcwd:
* modules/glob, modules/isapipe, modules/isdir, modules/javacomp:
* modules/lchown, modules/link, modules/linkat, modules/lseek:
* modules/lstat, modules/mkdir, modules/mkdir-p, modules/mkfifo:
* modules/mknod, modules/mkostemp, modules/mkostemps, modules/mkstemp:
* modules/mkstemps, modules/modechange, modules/mountlist:
* modules/open, modules/openat, modules/pread, modules/pt_chown:
* modules/ptsname, modules/pwrite, modules/read-file, modules/readlink:
* modules/relocatable-prog, modules/relocatable-prog-wrapper:
* modules/rename, modules/renameat, modules/same, modules/scandir:
* modules/stat, modules/symlink, modules/tempname, modules/tmpdir:
* modules/tmpfile, modules/unlink, modules/utimecmp, modules/utimens:
Depend on largefile as needed.
---
ChangeLog | 26 ++++++++++++++++++++++++++
m4/mkstemp.m4 | 3 +--
m4/tempname.m4 | 4 +---
modules/acl | 1 +
modules/canonicalize | 1 +
modules/canonicalize-lgpl | 1 +
modules/chdir-safer | 1 +
modules/chown | 1 +
modules/copy-file | 1 +
modules/euidaccess | 1 +
modules/fchdir | 1 +
modules/fdopendir | 1 +
modules/fflush | 1 +
modules/fileblocks | 2 +-
modules/fopen | 2 +-
modules/freopen | 2 +-
modules/fseek | 2 +-
modules/fseeko | 2 +-
modules/fsusage | 1 +
modules/ftell | 2 +-
modules/ftello | 2 +-
modules/ftruncate | 1 +
modules/fts | 1 +
modules/getcwd | 1 +
modules/glob | 1 +
modules/isapipe | 1 +
modules/isdir | 1 +
modules/javacomp | 2 +-
modules/lchown | 1 +
modules/link | 1 +
modules/linkat | 1 +
modules/lseek | 1 +
modules/lstat | 1 +
modules/mkdir | 1 +
modules/mkdir-p | 1 +
modules/mkfifo | 1 +
modules/mknod | 1 +
modules/mkostemp | 1 +
modules/mkostemps | 1 +
modules/mkstemp | 1 +
modules/mkstemps | 1 +
modules/modechange | 1 +
modules/mountlist | 1 +
modules/open | 2 +-
modules/openat | 1 +
modules/pread | 1 +
modules/pt_chown | 1 +
modules/ptsname | 1 +
modules/pwrite | 1 +
modules/read-file | 1 +
modules/readlink | 2 +-
modules/relocatable-prog | 2 +-
modules/relocatable-prog-wrapper | 2 +-
modules/rename | 1 +
modules/renameat | 1 +
modules/same | 1 +
modules/scandir | 2 +-
modules/stat | 1 +
modules/symlink | 1 +
modules/tempname | 1 +
modules/tmpdir | 2 +-
modules/tmpfile | 1 +
modules/unlink | 1 +
modules/utimecmp | 1 +
modules/utimens | 1 +
65 files changed, 90 insertions(+), 19 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 53a5121..82b4e59 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,29 @@
+2011-07-24 Paul Eggert <address@hidden>
+
+ largefile: add dependencies to this module
+ * m4/mkstemp.m4 (gl_FUNC_MKSTEMP):
+ * m4/tempname.m4 (gl_FUNC_GEN_TEMPNAME):
+ Do not require AC_SYS_LARGEFILE, since the containing module now
+ depends on the largefile module.
+ * modules/acl, modules/canonicalize, modules/canonicalize-lgpl:
+ * modules/chdir-safer, modules/chown, modules/copy-file:
+ * modules/euidaccess, modules/fchdir, modules/fdopendir:
+ * modules/fflush, modules/fileblocks, modules/fopen, modules/freopen:
+ * modules/fseek, modules/fseeko, modules/fsusage, modules/ftell:
+ * modules/ftello, modules/ftruncate, modules/fts, modules/getcwd:
+ * modules/glob, modules/isapipe, modules/isdir, modules/javacomp:
+ * modules/lchown, modules/link, modules/linkat, modules/lseek:
+ * modules/lstat, modules/mkdir, modules/mkdir-p, modules/mkfifo:
+ * modules/mknod, modules/mkostemp, modules/mkostemps, modules/mkstemp:
+ * modules/mkstemps, modules/modechange, modules/mountlist:
+ * modules/open, modules/openat, modules/pread, modules/pt_chown:
+ * modules/ptsname, modules/pwrite, modules/read-file, modules/readlink:
+ * modules/relocatable-prog, modules/relocatable-prog-wrapper:
+ * modules/rename, modules/renameat, modules/same, modules/scandir:
+ * modules/stat, modules/symlink, modules/tempname, modules/tmpdir:
+ * modules/tmpfile, modules/unlink, modules/utimecmp, modules/utimens:
+ Depend on largefile as needed.
+
2011-07-22 Bruno Haible <address@hidden>
select tests, pselect tests: Refactor.
diff --git a/m4/mkstemp.m4 b/m4/mkstemp.m4
index 0bc918c..ef3c689 100644
--- a/m4/mkstemp.m4
+++ b/m4/mkstemp.m4
@@ -1,4 +1,4 @@
-#serial 21
+#serial 22
# Copyright (C) 2001, 2003-2007, 2009-2011 Free Software Foundation, Inc.
# This file is free software; the Free Software Foundation
@@ -16,7 +16,6 @@
AC_DEFUN([gl_FUNC_MKSTEMP],
[
AC_REQUIRE([gl_STDLIB_H_DEFAULTS])
- AC_REQUIRE([AC_SYS_LARGEFILE])
AC_CHECK_FUNCS_ONCE([mkstemp])
if test $ac_cv_func_mkstemp = yes; then
diff --git a/m4/tempname.m4 b/m4/tempname.m4
index 633b671..5b726a6 100644
--- a/m4/tempname.m4
+++ b/m4/tempname.m4
@@ -1,4 +1,4 @@
-#serial 4
+#serial 5
# Copyright (C) 2006-2007, 2009-2011 Free Software Foundation, Inc.
# This file is free software; the Free Software Foundation
@@ -9,8 +9,6 @@
# it as a public API, and provide it on systems that are lacking.
AC_DEFUN([gl_FUNC_GEN_TEMPNAME],
[
- AC_REQUIRE([AC_SYS_LARGEFILE])
-
gl_PREREQ_TEMPNAME
])
diff --git a/modules/acl b/modules/acl
index f5913c2..64a7fec 100644
--- a/modules/acl
+++ b/modules/acl
@@ -13,6 +13,7 @@ m4/acl.m4
Depends-on:
error
gettext-h
+largefile
quote
sys_stat
diff --git a/modules/canonicalize b/modules/canonicalize
index bf3dc57..35c370e 100644
--- a/modules/canonicalize
+++ b/modules/canonicalize
@@ -13,6 +13,7 @@ errno
extensions
file-set
hash-triple
+largefile
lstat
memmove
nocrash
diff --git a/modules/canonicalize-lgpl b/modules/canonicalize-lgpl
index 7b77ac4..e271d92 100644
--- a/modules/canonicalize-lgpl
+++ b/modules/canonicalize-lgpl
@@ -12,6 +12,7 @@ stdlib
nocrash
alloca-opt [test $HAVE_CANONICALIZE_FILE_NAME = 0 || test
$REPLACE_CANONICALIZE_FILE_NAME = 1]
errno [test $HAVE_CANONICALIZE_FILE_NAME = 0 || test
$REPLACE_CANONICALIZE_FILE_NAME = 1]
+largefile [test $HAVE_CANONICALIZE_FILE_NAME = 0 || test
$REPLACE_CANONICALIZE_FILE_NAME = 1]
lstat [test $HAVE_CANONICALIZE_FILE_NAME = 0 || test
$REPLACE_CANONICALIZE_FILE_NAME = 1]
malloca [test $HAVE_CANONICALIZE_FILE_NAME = 0 || test
$REPLACE_CANONICALIZE_FILE_NAME = 1]
memmove [test $HAVE_CANONICALIZE_FILE_NAME = 0 || test
$REPLACE_CANONICALIZE_FILE_NAME = 1]
diff --git a/modules/chdir-safer b/modules/chdir-safer
index 095a408..72dce34 100644
--- a/modules/chdir-safer
+++ b/modules/chdir-safer
@@ -10,6 +10,7 @@ Depends-on:
errno
fchdir
fcntl-h
+largefile
open
same-inode
stdbool
diff --git a/modules/chown b/modules/chown
index 1c271f0..8a1b00b 100644
--- a/modules/chown
+++ b/modules/chown
@@ -9,6 +9,7 @@ m4/chown.m4
Depends-on:
unistd
open [test $HAVE_CHOWN = 0 || test $REPLACE_CHOWN = 1]
+largefile [test $HAVE_CHOWN = 0 || test $REPLACE_CHOWN = 1]
stat [test $HAVE_CHOWN = 0 || test $REPLACE_CHOWN = 1]
stdbool [test $HAVE_CHOWN = 0 || test $REPLACE_CHOWN = 1]
sys_stat [test $HAVE_CHOWN = 0 || test $REPLACE_CHOWN = 1]
diff --git a/modules/copy-file b/modules/copy-file
index 4ca553e..2eca7e4 100644
--- a/modules/copy-file
+++ b/modules/copy-file
@@ -12,6 +12,7 @@ binary-io
error
full-write
gettext-h
+largefile
open
safe-read
stdlib
diff --git a/modules/euidaccess b/modules/euidaccess
index a339e45..5355256 100644
--- a/modules/euidaccess
+++ b/modules/euidaccess
@@ -9,6 +9,7 @@ Depends-on:
unistd
extensions
group-member [test $HAVE_EUIDACCESS = 0]
+largefile [test $HAVE_EUIDACCESS = 0]
stat [test $HAVE_EUIDACCESS = 0]
sys_stat [test $HAVE_EUIDACCESS = 0]
diff --git a/modules/fchdir b/modules/fchdir
index 7b7cb04..0946bae 100644
--- a/modules/fchdir
+++ b/modules/fchdir
@@ -16,6 +16,7 @@ fcntl [test $HAVE_FCHDIR = 0]
fcntl-h [test $HAVE_FCHDIR = 0]
filenamecat-lgpl [test $HAVE_FCHDIR = 0]
getcwd-lgpl [test $HAVE_FCHDIR = 0]
+largefile [test $HAVE_FCHDIR = 0]
malloc-posix [test $HAVE_FCHDIR = 0]
open [test $HAVE_FCHDIR = 0]
realloc-posix [test $HAVE_FCHDIR = 0]
diff --git a/modules/fdopendir b/modules/fdopendir
index a1c2519..2a26bc4 100644
--- a/modules/fdopendir
+++ b/modules/fdopendir
@@ -12,6 +12,7 @@ dirent
extensions
errno [test $HAVE_FDOPENDIR = 0]
fchdir [test $HAVE_FDOPENDIR = 0]
+largefile [test $REPLACE_FDOPENDIR = 1]
openat-die [test $HAVE_FDOPENDIR = 0]
save-cwd [test $HAVE_FDOPENDIR = 0]
diff --git a/modules/fflush b/modules/fflush
index 16bdbb5..a5fc20e 100644
--- a/modules/fflush
+++ b/modules/fflush
@@ -11,6 +11,7 @@ stdio
fpurge [test $REPLACE_FFLUSH = 1]
ftello [test $REPLACE_FFLUSH = 1]
freading [test $REPLACE_FFLUSH = 1]
+largefile [test $REPLACE_FFLUSH = 1]
lseek [test $REPLACE_FFLUSH = 1]
unistd [test $REPLACE_FFLUSH = 1]
fseeko [test $REPLACE_FFLUSH = 1]
diff --git a/modules/fileblocks b/modules/fileblocks
index 2deff81..7e6bc0d 100644
--- a/modules/fileblocks
+++ b/modules/fileblocks
@@ -6,6 +6,7 @@ lib/fileblocks.c
m4/fileblocks.m4
Depends-on:
+largefile
configure.ac:
gl_FILEBLOCKS
@@ -23,4 +24,3 @@ GPL
Maintainer:
Jim Meyering
-
diff --git a/modules/fopen b/modules/fopen
index 13799e9..eed1940 100644
--- a/modules/fopen
+++ b/modules/fopen
@@ -7,6 +7,7 @@ m4/fopen.m4
Depends-on:
stdio
+largefile
unistd [test $REPLACE_FOPEN = 1]
configure.ac:
@@ -27,4 +28,3 @@ LGPLv2+
Maintainer:
Bruno Haible
-
diff --git a/modules/freopen b/modules/freopen
index 8704c04..f1e19bf 100644
--- a/modules/freopen
+++ b/modules/freopen
@@ -6,6 +6,7 @@ lib/freopen.c
m4/freopen.m4
Depends-on:
+largefile
stdio
configure.ac:
@@ -26,4 +27,3 @@ LGPL
Maintainer:
Bruno Haible
-
diff --git a/modules/fseek b/modules/fseek
index 87ab89e..f7ad712 100644
--- a/modules/fseek
+++ b/modules/fseek
@@ -6,6 +6,7 @@ lib/fseek.c
m4/fseek.m4
Depends-on:
+largefile
stdio
fseeko [test $REPLACE_FSEEK = 1]
@@ -26,4 +27,3 @@ LGPLv2+
Maintainer:
Bruno Haible
-
diff --git a/modules/fseeko b/modules/fseeko
index 07f78e5..4cd3c2c 100644
--- a/modules/fseeko
+++ b/modules/fseeko
@@ -8,6 +8,7 @@ m4/fseeko.m4
Depends-on:
extensions
+largefile
lseek
stdio
# Just to guarantee consistency between fseek() and fseeko().
@@ -33,4 +34,3 @@ LGPLv2+
Maintainer:
Bruno Haible
-
diff --git a/modules/fsusage b/modules/fsusage
index 33d956f..b447525 100644
--- a/modules/fsusage
+++ b/modules/fsusage
@@ -7,6 +7,7 @@ lib/fsusage.c
m4/fsusage.m4
Depends-on:
+largefile
stdbool
stdint
full-read [test $gl_cv_fs_space = yes]
diff --git a/modules/ftell b/modules/ftell
index 891fa72..9674392 100644
--- a/modules/ftell
+++ b/modules/ftell
@@ -8,6 +8,7 @@ m4/ftell.m4
Depends-on:
stdio
errno
+largefile
ftello [test $REPLACE_FTELL = 1]
configure.ac:
@@ -27,4 +28,3 @@ LGPLv2+
Maintainer:
Bruno Haible
-
diff --git a/modules/ftello b/modules/ftello
index 73aa811..486cbee 100644
--- a/modules/ftello
+++ b/modules/ftello
@@ -10,6 +10,7 @@ m4/ftello.m4
Depends-on:
stdio
extensions
+largefile
lseek [test $HAVE_FTELLO = 0 || test $REPLACE_FTELLO = 1]
# Just to guarantee consistency between ftell() and ftello().
ftell
@@ -34,4 +35,3 @@ LGPLv2+
Maintainer:
Bruno Haible
-
diff --git a/modules/ftruncate b/modules/ftruncate
index 6be248c..c0f77b6 100644
--- a/modules/ftruncate
+++ b/modules/ftruncate
@@ -12,6 +12,7 @@ lib/ftruncate.c
m4/ftruncate.m4
Depends-on:
+largefile
unistd
configure.ac:
diff --git a/modules/fts b/modules/fts
index d57b10c..86a7ed4 100644
--- a/modules/fts
+++ b/modules/fts
@@ -18,6 +18,7 @@ fcntl-h
fcntl-safer
hash
i-ring
+largefile
lstat
memmove
openat-safer
diff --git a/modules/getcwd b/modules/getcwd
index 6b764d2..ee8dfd4 100644
--- a/modules/getcwd
+++ b/modules/getcwd
@@ -10,6 +10,7 @@ m4/getcwd.m4
Depends-on:
unistd
extensions
+largefile [test $REPLACE_GETCWD = 1]
mempcpy [test $REPLACE_GETCWD = 1]
d-ino [test $REPLACE_GETCWD = 1]
memmove [test $REPLACE_GETCWD = 1]
diff --git a/modules/glob b/modules/glob
index 5a8b4ae..a731c27 100644
--- a/modules/glob
+++ b/modules/glob
@@ -10,6 +10,7 @@ m4/glob.m4
Depends-on:
extensions
+largefile
snippet/arg-nonnull
snippet/c++defs
snippet/warn-on-use
diff --git a/modules/isapipe b/modules/isapipe
index cc62ea8..446ac10 100644
--- a/modules/isapipe
+++ b/modules/isapipe
@@ -7,6 +7,7 @@ lib/isapipe.h
m4/isapipe.m4
Depends-on:
+largefile [test $HAVE_ISAPIPE = 0]
stdbool [test $HAVE_ISAPIPE = 0]
sys_stat [test $HAVE_ISAPIPE = 0]
unistd [test $HAVE_ISAPIPE = 0]
diff --git a/modules/isdir b/modules/isdir
index aab5f84..911c4e8 100644
--- a/modules/isdir
+++ b/modules/isdir
@@ -6,6 +6,7 @@ lib/isdir.c
lib/isdir.h
Depends-on:
+largefile
stat
configure.ac:
diff --git a/modules/javacomp b/modules/javacomp
index 6cb6845..1913eda 100644
--- a/modules/javacomp
+++ b/modules/javacomp
@@ -28,6 +28,7 @@ xvasprintf
c-strstr
gettext-h
javacomp-script
+largefile
configure.ac:
@@ -42,4 +43,3 @@ GPL
Maintainer:
Bruno Haible
-
diff --git a/modules/lchown b/modules/lchown
index 1ddecca..a1f0b94 100644
--- a/modules/lchown
+++ b/modules/lchown
@@ -9,6 +9,7 @@ Depends-on:
unistd
chown [test $HAVE_LCHOWN = 0 || test $REPLACE_LCHOWN = 1]
errno [test $HAVE_LCHOWN = 0 || test $REPLACE_LCHOWN = 1]
+largefile [test $HAVE_LCHOWN = 0 || test $REPLACE_LCHOWN = 1]
lstat [test $HAVE_LCHOWN = 0 || test $REPLACE_LCHOWN = 1]
stdbool [test $HAVE_LCHOWN = 0 || test $REPLACE_LCHOWN = 1]
sys_stat [test $HAVE_LCHOWN = 0 || test $REPLACE_LCHOWN = 1]
diff --git a/modules/link b/modules/link
index 5ea0ac2..d77e258 100644
--- a/modules/link
+++ b/modules/link
@@ -7,6 +7,7 @@ m4/link.m4
Depends-on:
unistd
+largefile [test $HAVE_LINK = 0 || test $REPLACE_LINK = 1]
stat [test $HAVE_LINK = 0 || test $REPLACE_LINK = 1]
strdup-posix [test $HAVE_LINK = 0 || test $REPLACE_LINK = 1]
sys_stat [test $HAVE_LINK = 0 || test $REPLACE_LINK = 1]
diff --git a/modules/linkat b/modules/linkat
index 3392e57..3b9b3f4 100644
--- a/modules/linkat
+++ b/modules/linkat
@@ -17,6 +17,7 @@ errno [test $HAVE_LINKAT = 0 || test
$REPLACE_LINKAT = 1]
fcntl-h [test $HAVE_LINKAT = 0 || test $REPLACE_LINKAT = 1]
filenamecat-lgpl [test $HAVE_LINKAT = 0 || test $REPLACE_LINKAT = 1]
getcwd-lgpl [test $HAVE_LINKAT = 0 || test $REPLACE_LINKAT = 1]
+largefile [test $HAVE_LINKAT = 0 || test $REPLACE_LINKAT = 1]
openat [test $HAVE_LINKAT = 0 || test $REPLACE_LINKAT = 1]
link [test $HAVE_LINKAT = 0 || test $REPLACE_LINKAT = 1]
link-follow [test $HAVE_LINKAT = 0 || test $REPLACE_LINKAT = 1]
diff --git a/modules/lseek b/modules/lseek
index 5b4a267..16d6070 100644
--- a/modules/lseek
+++ b/modules/lseek
@@ -6,6 +6,7 @@ lib/lseek.c
m4/lseek.m4
Depends-on:
+largefile
unistd
configure.ac:
diff --git a/modules/lstat b/modules/lstat
index dbe7e11..7fe97ca 100644
--- a/modules/lstat
+++ b/modules/lstat
@@ -7,6 +7,7 @@ m4/lstat.m4
Depends-on:
sys_stat
+largefile
dosname [test $REPLACE_LSTAT = 1]
stat [test $REPLACE_LSTAT = 1]
diff --git a/modules/mkdir b/modules/mkdir
index 032f1c5..cf16fec 100644
--- a/modules/mkdir
+++ b/modules/mkdir
@@ -8,6 +8,7 @@ m4/mkdir.m4
Depends-on:
sys_stat
dirname-lgpl [test $REPLACE_MKDIR = 1]
+largefile [test $REPLACE_MKDIR = 1]
configure.ac:
gl_FUNC_MKDIR
diff --git a/modules/mkdir-p b/modules/mkdir-p
index 562c1e2..55f7067 100644
--- a/modules/mkdir-p
+++ b/modules/mkdir-p
@@ -12,6 +12,7 @@ Depends-on:
error
fcntl-h
gettext-h
+largefile
lchmod
lchown
mkancesdirs
diff --git a/modules/mkfifo b/modules/mkfifo
index 7bf43b4..db22417 100644
--- a/modules/mkfifo
+++ b/modules/mkfifo
@@ -7,6 +7,7 @@ m4/mkfifo.m4
Depends-on:
sys_stat
+largefile [test $HAVE_MKFIFO = 0 || test $REPLACE_MKFIFO = 1]
stat [test $HAVE_MKFIFO = 0 || test $REPLACE_MKFIFO = 1]
configure.ac:
diff --git a/modules/mknod b/modules/mknod
index 1f647ef..e7acbf3 100644
--- a/modules/mknod
+++ b/modules/mknod
@@ -8,6 +8,7 @@ m4/mknod.m4
Depends-on:
sys_stat
extensions
+largefile [test $HAVE_MKNOD = 0 || test $REPLACE_MKNOD = 1]
mkfifo [test $HAVE_MKNOD = 0 || test $REPLACE_MKNOD = 1]
stat [test $HAVE_MKNOD = 0 || test $REPLACE_MKNOD = 1]
diff --git a/modules/mkostemp b/modules/mkostemp
index 299b01f..ee0ae4a 100644
--- a/modules/mkostemp
+++ b/modules/mkostemp
@@ -9,6 +9,7 @@ m4/mkostemp.m4
Depends-on:
stdlib
extensions
+largefile
tempname [test $HAVE_MKOSTEMP = 0]
configure.ac:
diff --git a/modules/mkostemps b/modules/mkostemps
index 2061f69..fb956f9 100644
--- a/modules/mkostemps
+++ b/modules/mkostemps
@@ -9,6 +9,7 @@ m4/mkostemps.m4
Depends-on:
stdlib
extensions
+largefile
tempname [test $HAVE_MKOSTEMPS = 0]
configure.ac:
diff --git a/modules/mkstemp b/modules/mkstemp
index 9ac5b3f..780908f 100644
--- a/modules/mkstemp
+++ b/modules/mkstemp
@@ -8,6 +8,7 @@ m4/mkstemp.m4
Depends-on:
stdlib
extensions
+largefile
tempname [test $HAVE_MKSTEMP = 0 || test $REPLACE_MKSTEMP = 1]
configure.ac:
diff --git a/modules/mkstemps b/modules/mkstemps
index cb3e572..61af8d5 100644
--- a/modules/mkstemps
+++ b/modules/mkstemps
@@ -8,6 +8,7 @@ m4/mkstemps.m4
Depends-on:
stdlib
extensions
+largefile
tempname [test $HAVE_MKSTEMPS = 0]
configure.ac:
diff --git a/modules/modechange b/modules/modechange
index b5b86a4..b4af7f4 100644
--- a/modules/modechange
+++ b/modules/modechange
@@ -8,6 +8,7 @@ lib/modechange.c
m4/modechange.m4
Depends-on:
+largefile
stat
stat-macros
stdbool
diff --git a/modules/mountlist b/modules/mountlist
index 1e7d22a..9139e8a 100644
--- a/modules/mountlist
+++ b/modules/mountlist
@@ -9,6 +9,7 @@ m4/fstypename.m4
m4/mountlist.m4
Depends-on:
+largefile
stdbool
stdint
strstr-simple
diff --git a/modules/open b/modules/open
index ea0f5ae..84b819c 100644
--- a/modules/open
+++ b/modules/open
@@ -8,6 +8,7 @@ m4/mode_t.m4
Depends-on:
fcntl-h
+largefile
stat [test $REPLACE_OPEN = 1]
configure.ac:
@@ -24,4 +25,3 @@ LGPLv2+
Maintainer:
Bruno Haible
-
diff --git a/modules/openat b/modules/openat
index b9ce4d4..5b32d85 100644
--- a/modules/openat
+++ b/modules/openat
@@ -24,6 +24,7 @@ fcntl-h
fdopendir
gettext-h
intprops
+largefile
lchown [test $HAVE_FCHOWNAT = 0 || test $REPLACE_FCHOWNAT = 1]
lstat
mkdir [test $HAVE_MKDIRAT = 0]
diff --git a/modules/pread b/modules/pread
index 537563a..7281cd6 100644
--- a/modules/pread
+++ b/modules/pread
@@ -8,6 +8,7 @@ m4/pread.m4
Depends-on:
unistd
extensions
+largefile
lseek [test $HAVE_PREAD = 0 || test $REPLACE_PREAD = 1]
read [test $HAVE_PREAD = 0 || test $REPLACE_PREAD = 1]
diff --git a/modules/pt_chown b/modules/pt_chown
index 0002ab7..719b4dd 100644
--- a/modules/pt_chown
+++ b/modules/pt_chown
@@ -6,6 +6,7 @@ lib/pt_chown.c
lib/pty-private.h
Depends-on:
+largefile
ptsname
stdlib
diff --git a/modules/ptsname b/modules/ptsname
index 985b79b..0f9dbdf 100644
--- a/modules/ptsname
+++ b/modules/ptsname
@@ -8,6 +8,7 @@ m4/ptsname.m4
Depends-on:
stdlib
extensions
+largefile [test $HAVE_PTSNAME = 0]
ttyname_r [test $HAVE_PTSNAME = 0]
configure.ac:
diff --git a/modules/pwrite b/modules/pwrite
index aadce1e..78843d4 100644
--- a/modules/pwrite
+++ b/modules/pwrite
@@ -8,6 +8,7 @@ m4/pwrite.m4
Depends-on:
unistd
extensions
+largefile
lseek [test $HAVE_PWRITE = 0 || test $REPLACE_PWRITE = 1]
write [test $HAVE_PWRITE = 0 || test $REPLACE_PWRITE = 1]
diff --git a/modules/read-file b/modules/read-file
index 0f380ca..ff7a75d 100644
--- a/modules/read-file
+++ b/modules/read-file
@@ -8,6 +8,7 @@ m4/read-file.m4
Depends-on:
ftello
+largefile
malloc-posix
realloc-posix
stdint
diff --git a/modules/readlink b/modules/readlink
index 431e201..82a8b90 100644
--- a/modules/readlink
+++ b/modules/readlink
@@ -7,6 +7,7 @@ m4/readlink.m4
Depends-on:
unistd
+largefile [test $HAVE_READLINK = 0 || test $REPLACE_READLINK = 1]
stat [test $HAVE_READLINK = 0 || test $REPLACE_READLINK = 1]
configure.ac:
@@ -27,4 +28,3 @@ LGPLv2+
Maintainer:
Bruno Haible
-
diff --git a/modules/relocatable-prog b/modules/relocatable-prog
index a7f50ac..47eeccc 100644
--- a/modules/relocatable-prog
+++ b/modules/relocatable-prog
@@ -23,6 +23,7 @@ stdbool
unistd
memcmp
strdup
+largefile
configure.ac:
gl_RELOCATABLE([$gl_source_base])
@@ -56,4 +57,3 @@ GPL
Maintainer:
Bruno Haible, Ben Pfaff
-
diff --git a/modules/relocatable-prog-wrapper b/modules/relocatable-prog-wrapper
index 8ff11d4..469e885 100644
--- a/modules/relocatable-prog-wrapper
+++ b/modules/relocatable-prog-wrapper
@@ -36,6 +36,7 @@ Depends-on:
alloca-opt
double-slash-root
errno
+largefile
pathmax
ssize_t
stdbool
@@ -62,4 +63,3 @@ GPL
Maintainer:
Bruno Haible, Ben Pfaff
-
diff --git a/modules/rename b/modules/rename
index 52ca382..30568db 100644
--- a/modules/rename
+++ b/modules/rename
@@ -9,6 +9,7 @@ Depends-on:
stdio
canonicalize-lgpl [test $REPLACE_RENAME = 1]
dirname-lgpl [test $REPLACE_RENAME = 1]
+largefile [test $REPLACE_RENAME = 1]
lstat [test $REPLACE_RENAME = 1]
rmdir [test $REPLACE_RENAME = 1]
same-inode [test $REPLACE_RENAME = 1]
diff --git a/modules/renameat b/modules/renameat
index 6e1012a..bca815d 100644
--- a/modules/renameat
+++ b/modules/renameat
@@ -13,6 +13,7 @@ fcntl-h
dosname [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1]
filenamecat-lgpl [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1]
getcwd-lgpl [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1]
+largefile [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1]
openat [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1]
rename [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1]
same-inode [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1]
diff --git a/modules/same b/modules/same
index 6401dfb..6fe54f8 100644
--- a/modules/same
+++ b/modules/same
@@ -10,6 +10,7 @@ m4/same.m4
Depends-on:
error
dirname
+largefile
same-inode
stat
stdbool
diff --git a/modules/scandir b/modules/scandir
index e071e54..0f3ba05 100644
--- a/modules/scandir
+++ b/modules/scandir
@@ -8,6 +8,7 @@ m4/scandir.m4
Depends-on:
dirent
extensions
+largefile
configure.ac:
gl_FUNC_SCANDIR
@@ -27,4 +28,3 @@ LGPL
Maintainer:
all, glibc
-
diff --git a/modules/stat b/modules/stat
index 8a349a7..4643421 100644
--- a/modules/stat
+++ b/modules/stat
@@ -7,6 +7,7 @@ m4/stat.m4
Depends-on:
sys_stat
+largefile
dosname [test $REPLACE_STAT = 1]
stdbool [test $REPLACE_STAT = 1]
verify [test $REPLACE_STAT = 1]
diff --git a/modules/symlink b/modules/symlink
index f6f1db2..16830f2 100644
--- a/modules/symlink
+++ b/modules/symlink
@@ -7,6 +7,7 @@ m4/symlink.m4
Depends-on:
unistd
+largefile [test $HAVE_SYMLINK = 0 || test $REPLACE_SYMLINK = 1]
lstat [test $HAVE_SYMLINK = 0 || test $REPLACE_SYMLINK = 1]
configure.ac:
diff --git a/modules/tempname b/modules/tempname
index 8bb8e83..ffdbe73 100644
--- a/modules/tempname
+++ b/modules/tempname
@@ -9,6 +9,7 @@ m4/tempname.m4
Depends-on:
extensions
gettimeofday
+largefile
lstat
stdint
sys_stat
diff --git a/modules/tmpdir b/modules/tmpdir
index a42fdc4..ecc3f27 100644
--- a/modules/tmpdir
+++ b/modules/tmpdir
@@ -7,6 +7,7 @@ lib/tmpdir.c
m4/tmpdir.m4
Depends-on:
+largefile
stdbool
sys_stat
@@ -24,4 +25,3 @@ LGPL
Maintainer:
Bruno Haible
-
diff --git a/modules/tmpfile b/modules/tmpfile
index d3a97fe..e98a8ee 100644
--- a/modules/tmpfile
+++ b/modules/tmpfile
@@ -7,6 +7,7 @@ m4/tmpfile.m4
Depends-on:
stdio
+largefile
pathmax [test $REPLACE_TMPFILE = 1]
tempname [test $REPLACE_TMPFILE = 1]
tmpdir [test $REPLACE_TMPFILE = 1]
diff --git a/modules/unlink b/modules/unlink
index 63720aa..b5858a3 100644
--- a/modules/unlink
+++ b/modules/unlink
@@ -8,6 +8,7 @@ m4/unlink.m4
Depends-on:
unistd
dosname [test $REPLACE_UNLINK = 1]
+largefile [test $REPLACE_UNLINK = 1]
lstat [test $REPLACE_UNLINK = 1]
configure.ac:
diff --git a/modules/utimecmp b/modules/utimecmp
index 398411e..93672d9 100644
--- a/modules/utimecmp
+++ b/modules/utimecmp
@@ -12,6 +12,7 @@ stat-time
time
utimens
intprops
+largefile
lstat
stdbool
stdint
diff --git a/modules/utimens b/modules/utimens
index 1a9687f..2bf46ff 100644
--- a/modules/utimens
+++ b/modules/utimens
@@ -11,6 +11,7 @@ m4/utimes.m4
Depends-on:
dup2
errno
+largefile
lstat
gettime
stat-time
--
1.7.4.4