bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] maint.mk: relax the default _gl_TS_function_match regexp


From: Jim Meyering
Subject: [PATCH] maint.mk: relax the default _gl_TS_function_match regexp
Date: Tue, 02 Aug 2011 14:55:27 +0200

I noticed a false positive that came down to spacing.
Fixed with this:

>From 8068b5d283630a295b2929b9dc6a65916b10f52f Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 2 Aug 2011 14:54:34 +0200
Subject: [PATCH] maint.mk: relax the default _gl_TS_function_match regexp

* top/maint.mk (_gl_TS_function_match): Don't require at least one
space between function name and "(" in an "extern" declaration.
That would fail to match a decl with no space there: extern void foo();
---
 ChangeLog    |    7 +++++++
 top/maint.mk |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6bcf68a..8133867 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-08-02  Jim Meyering  <address@hidden>
+
+       maint.mk: relax the default _gl_TS_function_match regexp
+       * top/maint.mk (_gl_TS_function_match): Don't require at least one
+       space between function name and "(" in an "extern" declaration.
+       That would fail to match a decl with no space there: extern void foo();
+
 2011-07-31  Iain Nicol  <address@hidden>

        git-version-gen: document that EXTRA_DIST must include .version
diff --git a/top/maint.mk b/top/maint.mk
index 6c1bf44..d364934 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1427,7 +1427,7 @@ ifeq (a,b)
 # do not need to be marked.  Symbols matching `__.*' are
 # reserved by the compiler, so are automatically excluded below.
 _gl_TS_unmarked_extern_functions ?= main usage
-_gl_TS_function_match ?= /^(?:$(_gl_TS_extern)) +.*?(\S+) +\(/
+_gl_TS_function_match ?= /^(?:$(_gl_TS_extern)) +.*?(\S+) *\(/

 # If your project uses a macro like "XTERN", then put
 # the following in cfg.mk to override this default:
--
1.7.6.351.gb35ac



reply via email to

[Prev in Thread] Current Thread [Next in Thread]