[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/8] fts: do not exhaust memory when processing million-entry
From: |
Paul Eggert |
Subject: |
Re: [PATCH 8/8] fts: do not exhaust memory when processing million-entry directories |
Date: |
Thu, 18 Aug 2011 11:32:16 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 |
Thanks for all that work to make fts better! A couple of minor things
about comments:
On 08/18/2011 06:53 AM, Jim Meyering wrote:
> + into memory at once. However, When an fts_compar function
The "However," can be removed (there are too many Buts etc. in the
neighborhood already ...).
> + The other conditionals ensure
> + that we are using the *at functions (FTS_CWDFD) and that we
> + are not in no-chdir mode (induced by use of FTS_LOGICAL). */
Are these other conditionals independent of whether we want to avoid
putting too many entries in RAM? If so, perhaps we should remove these
other conditionals; if not, it'd help for the comment to explain why not.
- [PATCH 1/8] maint: fts.c: remove #if-0'd FTS_WHITEOUT code, (continued)
- [PATCH 3/8] maint: fts.c: correct off-by-one indentation, Jim Meyering, 2011/08/18
- [PATCH 2/8] maint: fts.c: move __opendir2 #define "up" out of function body, Jim Meyering, 2011/08/18
- [PATCH 7/8] fts: move decl of "dp" into while loop; split long line, Jim Meyering, 2011/08/18
- [PATCH 5/8] maint: fts: give __opendir2 a new parameter, Jim Meyering, 2011/08/18
- [PATCH 6/8] fts: add/use new struct member, fts_dirp, Jim Meyering, 2011/08/18
- [PATCH 8/8] fts: do not exhaust memory when processing million-entry directories, Jim Meyering, 2011/08/18
- Re: [PATCH 8/8] fts: do not exhaust memory when processing million-entry directories,
Paul Eggert <=
Re: fts: do not exhaust memory when processing million-entry directory, Pádraig Brady, 2011/08/18