bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 8/8] fts: do not exhaust memory when processing million-entry


From: Paul Eggert
Subject: Re: [PATCH 8/8] fts: do not exhaust memory when processing million-entry directories
Date: Thu, 18 Aug 2011 11:32:16 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11

Thanks for all that work to make fts better!  A couple of minor things
about comments:

On 08/18/2011 06:53 AM, Jim Meyering wrote:

> +           into memory at once.  However, When an fts_compar function

The "However," can be removed (there are too many Buts etc. in the
neighborhood already ...).

> +           The other conditionals ensure
> +           that we are using the *at functions (FTS_CWDFD) and that we
> +           are not in no-chdir mode (induced by use of FTS_LOGICAL).  */

Are these other conditionals independent of whether we want to avoid
putting too many entries in RAM?  If so, perhaps we should remove these
other conditionals; if not, it'd help for the comment to explain why not.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]