bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: canonicalize_file_name should support win32 shortcuts


From: Sam Steingold
Subject: Re: canonicalize_file_name should support win32 shortcuts
Date: Tue, 23 Aug 2011 14:46:12 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

> * Eric Blake <address@hidden> [2011-08-23 11:47:57 -0600]:
>
> On 08/23/2011 11:31 AM, Sam Steingold wrote:
>>
>>> Maybe we should rename the canonicalize module to instead be
>>> canonicalize_filename_mode, since it does _not_ provide canonicalize()
>>> (well, canonicalize_filename_mode(file, CAN_EXISTING) is identical to
>>> canonicalize(), but the other modes are what introduce the baggage).
>>
>> yes, I think there should be a very minimalist realpath module whose job
>> is to provide the posix realpath with minimum dependencies (well,
>> minimum dependencies is my constant mantra, applicable to extension
>> modules just as much as to portability ones).
>
> canonicalize-lgpl _is_ the minimalize realpath()/canonicalize()
> module.

http://article.gmane.org/gmane.comp.lib.gnulib.bugs:26452

Indeed, much better:

$ wc `hg st -u | cut -c2-`
  378  1324 10439 src/gllib/canonicalize-lgpl.c
   53   261  2011 src/gllib/dosname.h
   91   490  3191 src/gllib/lstat.c
   48   227  1525 src/gllib/pathmax.h
   74   347  2355 src/gllib/readlink.c
  105   458  3425 src/gllib/stat.c
  658  2489 18324 src/gllib/sys_stat.in.h
  249  1093  9223 src/gllib/time.in.h
   94   274  2986 src/glm4/canonicalize.m4
   38   212  1621 src/glm4/double-slash-root.m4
   69   274  2652 src/glm4/lstat.m4
   13    55   441 src/glm4/pathmax.m4
   62   210  2218 src/glm4/readlink.m4
   66   250  2436 src/glm4/stat.m4
   82   259  3278 src/glm4/sys_stat_h.m4
  109   305  4247 src/glm4/time_h.m4
 2189  8528 70372 total

Still I get 2000+ lines to replace 200- lines I have.

-- 
Sam Steingold (http://sds.podval.org/) on CentOS release 5.6 (Final) X 
11.0.60900031
http://www.memritv.org http://mideasttruth.com
http://openvotingconsortium.org http://ffii.org http://dhimmi.com
Why do you never call me back after I scream that I will never talk to you 
again?!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]