[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] test-parse-datetime.c: accommodate a relatively strict gcc w
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH] test-parse-datetime.c: accommodate a relatively strict gcc warning |
|
Date: |
Wed, 31 Aug 2011 16:53:08 +0200 |
Eric Blake wrote:
> On 08/31/2011 08:44 AM, Jim Meyering wrote:
>> @@ -93,21 +93,21 @@ tm_diff (struct tm const *a, struct tm const *b)
>> }
>> #endif /* ! HAVE_TM_GMTOFF */
>>
>> -long
>> -gmt_offset()
>> +static long
>> +gmt_offset ()
>
> Shouldn't this be:
>
> static long
> gmt_offset (void)
>
> to avoid yet more warnings about K&R declaration syntax?
Probably, but that change was not required to get past coreutils'
set of gcc warnings.
But it's a good point, so I will make that change along with
the upcoming doc change. Thanks.