bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils-8.12.178-df9cd on Solaris 10


From: Bruno Haible
Subject: Re: coreutils-8.12.178-df9cd on Solaris 10
Date: Mon, 5 Sep 2011 11:28:29 +0200
User-agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; )

> > So, in summary, there are two problems:
> >   - 'cp' creates a nontrivial ACL for a directory when the original
> >     directory had none.
> > ...
> This patch fixes it. I'm committing it in gnulib.

We shouldn't need coreutils tests in order to detect that a gnulib module
is not working well. I'm extending the ACL tests in gnulib so that they
detect the failure before the fix:

  mode = 4700: tmpfile1 got an ACL
  FAIL: test-set-mode-acl-2.sh
  files tmpfile0 and tmpfile1: different ACL entry #2: different ids -1 and 0
  FAIL: test-copy-acl-2.sh

Basically, it's enough to try different values of TMPDIR, instead of always
trying only TMPDIR=/tmp.


2011-09-05  Bruno Haible  <address@hidden>

        copy-file: Try unit tests on more file systems.
        * tests/test-copy-file-1.sh: New file.
        * tests/test-copy-file-2.sh: New file.
        * modules/copy-file-tests (Files): Add them.
        (Makefile.am): Add them to TESTS.

        acl: Try unit tests on more file systems.
        * tests/test-file-has-acl-1.sh: New file.
        * tests/test-file-has-acl-2.sh: New file.
        * tests/test-set-mode-acl-1.sh: New file.
        * tests/test-set-mode-acl-2.sh: New file.
        * tests/test-copy-acl-1.sh: New file.
        * tests/test-copy-acl-2.sh: New file.
        * modules/acl-tests (Files): Add them.
        (Makefile.am): Add them to TESTS.

-- 
In memoriam Moshe Weinberg <http://en.wikipedia.org/wiki/Moshe_Weinberg>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]