Re: maint.mk syntax check problems

[Martin von Gagern]

Re-sending for the mailing list, forgot that a moment ago.

On 14.09.2011 16:49, Simon Josefsson wrote:
> I'm not a fan of separate shell scripts, each new file to deal with
> seems to incur a small maintainance cost over time -- consider when they
> are renamed or moved.  I think gnulib already install a large number of
> of files into projects using gnulib, so we should be conservative about
> increasing that number needlessly.

You could integrate vc-list-files into that file as a function, thus
keeping the number of files the same. Would have the added benefit that
the result of the listing could be cached in a bash array, making my own
caching from https://github.com/gagern/gnulib/commit/40533f3fa4b9 obsolete.

I guess you could also turn this into a perl script instead of a bash
script, but while that would allow integration of the existing perl
scripts useless-if-before-free, announce-gen and update-copyright, and
would make some regexp checks easier, it would mean rewriting the checks
considerably. Some checks would probably be less readable than their
shell equivalent. And perhaps some projects might be using one of the
existing perl scripts independently from maint.mk.

> In general I'm in favor of as simple code as possible, but I think here
> the cost with many new shell scripts outweigh the benefit of improved
> code.

Just to make certain there is no misunderstanding: I'm thinking about a
single file containing all these scripts as functions, not multiple
files with one test each, as your answer might possibly suggest.

Martin

signature.asc
Description: OpenPGP digital signature