Re: test-renameat does not cleanup after itself

[Jim Meyering]

Tom G. Christensen wrote:
> Running make distcheck on CentOS 5 dies with:
> ERROR: files left in build directory after distclean:
> ./gltests/test-renameat.too
> make[1]: *** [distcleancheck] Error 1

Thanks for the report.
That's nearly identical to the one I fixed for linkat on Oct 1.
Here's a fix:

>From 775119f83d459107178933d4baa8886e91b19a9c Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 10 Oct 2011 08:49:37 +0200
Subject: [PATCH] test-renameat: don't leave behind a temporary file

* tests/test-renameat.c (main): Don't forget to remove a temporary file.
  ERROR: files left in build directory after distclean:
  ./gltests/test-renameat.too
  make[1]: *** [distcleancheck] Error 1
Reported by Tom G. Christensen.
---
 ChangeLog             |    9 +++++++++
 tests/test-renameat.c |    1 +
 2 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 44f1e18..69ed191 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2011-10-10  Jim Meyering  <address@hidden>
+
+       test-renameat: don't leave behind a temporary file
+       * tests/test-renameat.c (main): Don't forget to remove a temporary file.
+         ERROR: files left in build directory after distclean:
+         ./gltests/test-renameat.too
+         make[1]: *** [distcleancheck] Error 1
+       Reported by Tom G. Christensen.
+
 2011-10-09  Bruno Haible  <address@hidden>

        rint: Determine RINT_LIBM correctly on AIX 7.
diff --git a/tests/test-renameat.c b/tests/test-renameat.c
index 9ca1787..9b67da0 100644
--- a/tests/test-renameat.c
+++ b/tests/test-renameat.c
@@ -83,6 +83,7 @@ main (void)
     ASSERT (renameat (AT_FDCWD, BASE "oo", 99, "bar") == -1);
     ASSERT (errno == EBADF);
   }
+  ASSERT (unlink (BASE "oo") == 0);

   /* Test basic rename functionality, using current directory.  */
   result = test_rename (do_rename, false);
--
1.7.7.rc0.362.g5a14