Re: [PATCH] posix_openpt: new module

[Bruno Haible]

Jim Meyering wrote:
> diff --git a/lib/posix_openpt.c b/lib/posix_openpt.c
> index 3b7d4cf..19cd0b6 100644
> --- a/lib/posix_openpt.c
> +++ b/lib/posix_openpt.c
> @@ -46,5 +46,3 @@ posix_openpt (int flags)
> 
>    return master;
>  }
> -
> -#endif

Another pretty basic failure, that makes me think I'm the first one to test
this code, is this compilation failure on Solaris 9 and HP-UX 11.23:

cc -O -DHAVE_CONFIG_H -I. -I..  -DGNULIB_STRICT_CHECKING=1  -DIN_GNULIB_TESTS=1 
 -I. -I.  -I.. -I./..  -I../gllib -I./../gllib    -g -c test-posix_openpt.c
"test-posix_openpt.c", line 24: undefined symbol: posix_openpt
"test-posix_openpt.c", line 24: warning: improper pointer/integer combination: 
op "="
"test-posix_openpt.c", line 24: non-constant initializer: op "NAME"
"test-posix_openpt.c", line 45: function designator is not of function type
"test-posix_openpt.c", line 45: warning: improper pointer/integer combination: 
op "="
"test-posix_openpt.c", line 76: cannot recover from previous errors
cc: acomp failed for test-posix_openpt.c
*** Error code 2

$ grep POSIX_OPENPT config.status 
S["HAVE_POSIX_OPENPT"]="1"
S["GNULIB_POSIX_OPENPT"]="1"
D["GNULIB_TEST_POSIX_OPENPT"]=" 1"
$ grep posix_openpt log1
checking for posix_openpt... no
checking for posix_openpt... (cached) no
checking whether posix_openpt is declared without a macro... no

This fixes it. And also removes a piece of m4 code that is 1. at the wrong
place (we are now putting prerequisites of the lib/*.c files into
gl_PREREQ_FOO macros systematically) and 2. unnecessary (because _getpty
exists on IRIX only, but IRIX has /dev/ptmx).


2011-10-20  Bruno Haible  <address@hidden>

        posix_openpt: Fix autoconf macro.
        * m4/posix_openpt.m4 (gl_FUNC_POSIX_OPENPT): Fix variable name. Remove
        unneeded check for _getpty.

--- m4/posix_openpt.m4.orig     Thu Oct 20 16:23:08 2011
+++ m4/posix_openpt.m4  Thu Oct 20 16:05:24 2011
@@ -1,4 +1,4 @@
-# posix_openpt.m4 serial 1
+# posix_openpt.m4 serial 2
 dnl Copyright (C) 2011 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -12,10 +12,8 @@
   AC_REQUIRE([AC_USE_SYSTEM_EXTENSIONS])
 
   AC_CHECK_FUNCS_ONCE([posix_openpt])
-  if test $ac_cv_have_posix_openpt != yes; then
+  if test $ac_cv_func_posix_openpt != yes; then
     dnl The system does not have posix_openpt.
     HAVE_POSIX_OPENPT=0
-    dnl Prerequisites of lib/posix_openpt.c in this case.
-    AC_CHECK_FUNCS([_getpty])
   fi
 ])

-- 
In memoriam Eduard Brücklmeier <http://en.wikipedia.org/wiki/Eduard_Brücklmeier>