bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] gitlog-to-changelog: treat messages without non-blank lines


From: Dmitry V. Levin
Subject: [PATCH 1/2] gitlog-to-changelog: treat messages without non-blank lines as empty
Date: Sun, 30 Oct 2011 05:01:00 +0400

* build-aux/gitlog-to-changelog: Move the code that removes leading and
trailing blank lines before the code that issues a warning about an
empty commit message.
---
 ChangeLog                     |    7 +++++++
 build-aux/gitlog-to-changelog |    8 ++++----
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f4711dc..088d239 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-10-29  Dmitry V. Levin  <address@hidden>
+
+       gitlog-to-changelog: treat messages without non-blank lines as empty.
+       * build-aux/gitlog-to-changelog: Move the code that removes leading and
+       trailing blank lines before the code that issues a warning about an
+       empty commit message.
+
 2011-10-27  Bruno Haible  <address@hidden>
 
        fstat: Tweak documentation.
diff --git a/build-aux/gitlog-to-changelog b/build-aux/gitlog-to-changelog
index 4559704..a5fd80d 100755
--- a/build-aux/gitlog-to-changelog
+++ b/build-aux/gitlog-to-changelog
@@ -152,6 +152,10 @@ sub quoted_cmd(@)
       # Omit "Signed-off-by..." lines.
       @line = grep !/^Signed-off-by: .*>$/, @line;
 
+      # Remove leading and trailing blank lines.
+      while ($line[0] =~ /^\s*$/) { shift @line; }
+      while ($line[$#line] =~ /^\s*$/) { pop @line; }
+
       # If there were any lines
       if (@line == 0)
         {
@@ -159,10 +163,6 @@ sub quoted_cmd(@)
         }
       else
         {
-          # Remove leading and trailing blank lines.
-          while ($line[0] =~ /^\s*$/) { shift @line; }
-          while ($line[$#line] =~ /^\s*$/) { pop @line; }
-
           # Prefix each non-empty line with a TAB.
           @line = map { length $_ ? "\t$_" : '' } @line;
 
-- 
ldv



reply via email to

[Prev in Thread] Current Thread [Next in Thread]