Re: [PATCH 3/4] ptsname_r: port to Solaris

[Bruno Haible]

Eric Blake wrote:
> +     * lib/ptsname_r.c (ptsname_r): Provide wrapper around ptsname,
> +     when it is available, since Solaris isatty doesn't set errno.
> ...
> I would expect feedback
> to include whether ptsname_r should drag in locking

The new ptsname_r replacement is active on platforms where our old
ptsname replacement was not needed:
   MacOS X 10.5, FreeBSD 6.0, NetBSD 5.0, AIX 5.1, HP-UX 11, IRIX 6.5,
   Solaris 11 2010-11, Cygwin.

Having ptsname_r call ptsname brings up the issue of locking, and seems
backwards. It would be nicer to have ptsname_r be built only on top of
isatty() and ttyname_r(). The question is whether this is possible, and
only testing on all of the above systems can show.

Can you therefore please commit parts 1 and 2 only, and hold off for
parts 3 and 4, to give me time to investigate whether the simpler
implementation essentially works on all platforms?

Bruno
-- 
In memoriam The inmates of the Daugavpils Ghetto 
<http://en.wikipedia.org/wiki/Daugavpils_Ghetto>