Re: [PATCH 1/4] ptsname_r: new module

[Eric Blake]

On 11/08/2011 04:01 AM, Bruno Haible wrote:
> Hi Eric,
>
> This patch looks fine.
>
> > address@hidden
> > +This function is missing on some platforms:
> > +MacOS X 10.5, FreeBSD 6.0, NetBSD 5.0, OpenBSD 3.8, Minix 3.1.8, AIX
> > +5.1, HP-UX 11, IRIX 6.5, Solaris 11 2010-11, Cygwin 1.7.9, mingw, MSVC 9, BeOS.
> >   @end itemize
>
> Could you please break the line after a comma? There are so many
> files in doc/*/*.texi that the only reasonable way to make mass modifications
> is through tools like 'grep' and 'sed'. Such scripted modifications became
> complicated if I can't rely on "grep 'AIX 5'" to find the references to AIX 5.

Pushed with that fixed.

As for things like address@hidden just to prevent paragraph fill from 
breaking things, it seems like it would be tough to be consistent 
without some syntax check rules to enforce things.  I could live with it 
if we decide to do it, but it seems like a lot of files will have to be 
fixed first (thankfully, it also seems rather automatable to make the fix).

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org