Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

[Simon Josefsson]

Jim Meyering <address@hidden> writes:

> Simon Josefsson wrote:
>
>> Eric Blake <address@hidden> writes:
>>
>>> On 11/29/2011 02:46 PM, Eric Blake wrote:
>>>>> Unless there are objections (portability?)
>>>>
>>>> Aargh.  I just reread C99.
>>>>
>>>> F (and f) for float, and L (or l) for long double are required, but D
>>>> (or d) for double is a GNU extension.
>>>>
>>>> Since we can't silence the warning without adding an explicit 'D', but
>>>> 'D' is not standardized, I have changed my mind.  Let's nuke the warning.
>>>
>>> So for starters, I'm pushing this:
>>
>> Please revert or change this -- like other warnings, this warning is
>> useful in some projects and not useful in others, and the idea with
>> manywarnings.m4 is that all warnings should be enabled and each project
>> has to disable the warnings they don't like incrementally.  See
>> doc/manywarnings.texi for background.
>>
>> The function you added modified was this one:
>>
>> # gl_MANYWARN_ALL_GCC(VARIABLE)
>> # -----------------------------
>> # Add all documented GCC (currently as per version 4.4) warning
>> # parameters to variable VARIABLE.
>
> Hi Simon,
>
> Isn't that 4.4 out of date, now?
> Considering you updated the list recently, I'd expect 4.6 there.

Oops.  I removed the reference to a version there, it is not useful in
the general function documentation.

/Simon