Re: spurious message about include files from `bootstrap' script

[Jim Meyering]

Bruno Haible wrote:
> Hi Stefano,
>>   You may need to add #include directives for the following .h files.
>>     #include <alloca.h>
>>     ... [SNIP]
>>     #include <unistd.h>
>>     #include <wchar.h>
>>     /* Include only after all system include files.  */
>>     GPL
>>     License
>>     #include "acl.h"
>>     #include "alignof.h"
>>     # ... [SNIP]
>>     #include "yesno.h"
>>
>>   You may need to use the following Makefile variables when linking.
>>   ...
>
> Thanks for the report. This should fix it.
>
> Jim, these modules came from codeutils. The same bug is also present in
> the coreutils files
>
>   gl/modules/heap
>   gl/modules/randint
>   gl/modules/randperm
>   gl/modules/randread
>
> If you start a new module by making a copy of modules/TEMPLATE, this mistake
> can't happen.

Thanks to both of you.

Bruno, what do you think about making gnulib-tool warn about
that syntax error?

Fixed with this:

  perl -pi -e 's/^(License)$/$1:/' $(git grep -l '^License$' gl)


>From 79c5fcc681b823a4e5fbb8fd1baa47db4eccd86c Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 3 Dec 2011 14:04:17 +0100
Subject: [PATCH] maint: add missing ":" after "License" in local gnulib
 module files

This avoids spurious diagnostics when running our "bootstrap" script.
* gl/modules/heap: Append colon after "License".
* gl/modules/randint: Likewise.
* gl/modules/randperm: Likewise.
* gl/modules/randread: Likewise.
Reported by Stefano Lattarini.  Diagnosed by Bruno Haible.
---
 gl/modules/heap     |    2 +-
 gl/modules/randint  |    2 +-
 gl/modules/randperm |    2 +-
 gl/modules/randread |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gl/modules/heap b/gl/modules/heap
index cd97e29..97e9df2 100644
--- a/gl/modules/heap
+++ b/gl/modules/heap
@@ -17,7 +17,7 @@ lib_SOURCES += heap.c heap.h
 Include:
 "heap.h"

-License
+License:
 GPL

 Maintainer:
diff --git a/gl/modules/randint b/gl/modules/randint
index 4485581..37025b7 100644
--- a/gl/modules/randint
+++ b/gl/modules/randint
@@ -17,7 +17,7 @@ lib_SOURCES += randint.c randint.h
 Include:
 "randint.h"

-License
+License:
 GPL

 Maintainer:
diff --git a/gl/modules/randperm b/gl/modules/randperm
index daf9e32..1fa2612 100644
--- a/gl/modules/randperm
+++ b/gl/modules/randperm
@@ -18,7 +18,7 @@ lib_SOURCES += randperm.c randperm.h
 Include:
 "randperm.h"

-License
+License:
 GPL

 Maintainer:
diff --git a/gl/modules/randread b/gl/modules/randread
index 33485c5..14af00e 100644
--- a/gl/modules/randread
+++ b/gl/modules/randread
@@ -28,7 +28,7 @@ lib_SOURCES += randread.c randread.h rand-isaac.c rand-isaac.h
 Include:
 "randread.h"

-License
+License:
 GPL

 Maintainer:
--
1.7.8.rc4