Re: [PATCH gnulib 3/4] select, poll, isatty: Avoid warnings on x86_64 mingw64.

[Bruno Haible]

Marc-André Lureau wrote:
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,14 @@
> +2012-01-25  Marc-André Lureau  <address@hidden>
> +
> +     select, poll, isatty: Avoid warnings on x86_64 mingw64.
> +     * lib/select.c (IsConsoleHandle): Use intptr_t to convert handle
> +     pointer to an integer. Fix warnings with MinGW64 x64.
> +     * lib/poll.c (IsConsoleHandle): Likewise.
> +     * lib/isatty.c (IsConsoleHandle): Likewise.
> +     * modules/select (Depends-on): Add stdint.
> +     * modules/poll (Depends-on): Likewise.
> +     * modules/isatty (Depends-on): Likewise.

Thanks. In this case, we don't need the dependency to the 'stdint'
module, though: The cast is in code branches that apply only to native
Windows platforms, and I've verified that just changing the case does
not introdocuce a compilation error in mingw, mingw64 (both 32-bit and 64-bit)
and MSVC 9. So I've committed only the lib/*.c changes in your name.

Note that the "tiny change" annotation only means that we didn't have to
worry about copyright assignment so far. If you would like to contribute
larger patches to gnulib, then it would be good if you could start the
FSF copyright assignment process for gnulib, as described in
http://www.gnu.org/prep/maintain/maintain.html#Copyright-Papers
Regarding to how to get the assignment papers from your employer, Jim
can certainly tell you a word.


2012-01-28  Marc-André Lureau  <address@hidden>  (tiny change)

        select, poll, isatty: Avoid warnings on x86_64 mingw64.
        * lib/select.c (IsConsoleHandle): Use intptr_t to convert handle
        pointer to an integer.
        * lib/poll.c (IsConsoleHandle): Likewise.
        * lib/isatty.c (IsConsoleHandle): Likewise.