Re: [PATCH] GNUmakefile: simplify detection of unconfigured trees

[Eric Blake]

On 02/16/2012 12:38 PM, Stefano Lattarini wrote:
> * top/GNUmakefile: Use $(wildcard) instead of $(shell) to determine
> whether the tree make is being run from is already configured or
> not.  Related simplifications.
> ---
>  ChangeLog       |    7 +++++++
>  top/GNUmakefile |   14 ++------------
>  2 files changed, 9 insertions(+), 12 deletions(-)
> 

>  # If the user runs GNU make but has not yet run ./configure,
>  # give them a diagnostic.
> -_have-Makefile := $(shell test -f Makefile && echo yes)
> -ifeq ($(_have-Makefile),yes)
> +_gl-Makefile := $(wildcard [M]akefile)

According to 'info make', both 'makefile' and 'Makefile' serve as
defaults, so I'd rather see this as $(wildcard [mM]akefile).

> +ifneq ($(_gl-Makefile),)

But it's a cool simplification.  You've got my ACK.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature