Re: [PATCH] GNUmakefile: simplify detection of unconfigured trees

[Stefano Lattarini]

On 02/16/2012 09:02 PM, Eric Blake wrote:
> On 02/16/2012 12:38 PM, Stefano Lattarini wrote:
>> * top/GNUmakefile: Use $(wildcard) instead of $(shell) to determine
>> whether the tree make is being run from is already configured or
>> not.  Related simplifications.
>> ---
>>  ChangeLog       |    7 +++++++
>>  top/GNUmakefile |   14 ++------------
>>  2 files changed, 9 insertions(+), 12 deletions(-)
>>
> 
>>  # If the user runs GNU make but has not yet run ./configure,
>>  # give them a diagnostic.
>> -_have-Makefile := $(shell test -f Makefile && echo yes)
>> -ifeq ($(_have-Makefile),yes)
>> +_gl-Makefile := $(wildcard [M]akefile)
> 
> According to 'info make', both 'makefile' and 'Makefile' serve as
> defaults, so I'd rather see this as $(wildcard [mM]akefile).
>
This would be theoretically more correct, true, but honestly I've never
seen a client project of gnulib (nor of the autotools for that matter)
that uses 'makefile' instead of 'Makefile'.  More importantly, this change
of mine is meant not to entail any semantic change, so I'd rather see
your proposed improvement implemented in a follow-up.  Does that sounds
OK to you?

>> +ifneq ($(_gl-Makefile),)
> 
> But it's a cool simplification.  You've got my ACK.
> 
Thanks.  I will anyway wait until tomorrow before pushing, to give the
others some more time to chime in.

Thanks,
  Stefano