bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] quote: fuse into quotearg


From: Bruno Haible
Subject: Re: [PATCH] quote: fuse into quotearg
Date: Wed, 07 Mar 2012 11:40:41 +0100
User-agent: KMail/4.7.4 (Linux/3.1.0-1.2-desktop; KDE/4.7.4; x86_64; ; )

Paul Eggert wrote:
> --- a/modules/quote
> +++ b/modules/quote
> @@ -3,7 +3,6 @@ Quote arguments for use in error messages.
>  
>  Files:
>  lib/quote.h
> -lib/quote.c
>  m4/quote.m4
>  
>  Depends-on:
> @@ -12,9 +11,6 @@ quotearg
>  configure.ac:
>  gl_QUOTE
>  
> -Makefile.am:
> -lib_SOURCES += quote.c
> -
>  Include:
>  "quote.h"

Even when you remove the contents of a section of the module description
file, it's a good idea to keep the sectioning in place. Why? Because when
the section needs to be re-introduced, it's good if the sections stay in
the same order: this makes it easier to review and 'diff' module description
files.

Consider all sections listed in modules/TEMPLATE as mandatory (except for
tests, for which we have modules/TEMPLATE-TESTS).


2012-03-07  Bruno Haible  <address@hidden>

        quote: Adhere to common module description layout.
        * modules/quote (Makefile.am): Add back empty section.

--- modules/quote.orig  Wed Mar  7 11:36:14 2012
+++ modules/quote       Wed Mar  7 11:33:17 2012
@@ -11,6 +11,8 @@
 configure.ac:
 gl_QUOTE
 
+Makefile.am:
+
 Include:
 "quote.h"
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]