bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] frexp-nolibm-tests: include required test-frexp.h


From: Bruno Haible
Subject: Re: [PATCH] frexp-nolibm-tests: include required test-frexp.h
Date: Thu, 08 Mar 2012 04:30:28 +0100
User-agent: KMail/4.7.4 (Linux/3.1.0-1.2-desktop; KDE/4.7.4; x86_64; ; )

Hi Jim,

> I tried to build coreutils using the latest from gnulib
> and saw compilation failures in the new tests:
> 
>   test-frexp.c:59:24: fatal error: test-frexp.h: No such file or directory
>   compilation terminated.
>   test-frexpl.c:66:24: fatal error: test-frexp.h: No such file or directory
>   compilation terminated.

Oops. Indeed, I can reproduce it with
  $ ./gnulib-tool --test --with-tests frexp-nolibm
and
  $ ./gnulib-tool --test --with-tests frexpl-nolibm

> * modules/frexp-nolibm-tests (Files): Add test-frexp.h, which
> is included by test-frexp.c.
> Also add tests/randomd.c, required due to test-frexp.h's use
> of RANDOM.
> (test_frexp_nolibm_SOURCES): Now that we're using
> randomd/RANDOM, we must link with randomd.c.

This is good and fixes half of the problem. I added the other half
(module 'frexpl-nolibm-tests') and pushed it.

>  2012-03-07  Jim Meyering  <address@hidden>
> 
> +     frexp-nolibm-tests: include required test-frexp.h
> +     * modules/frexp-nolibm-tests (Files): Add test-frexp.h, which
> +     is included by test-frexp.c.
> +     Also add tests/randomd.c, required due to test-frexp.h's use
> +     of RANDOM.
> +     (test_frexp_nolibm_SOURCES): Now that we're using
> +

One line of ChangeLog got lost. With 'vc-dwim --commit' this would not
happen, I think?


2012-03-07  Jim Meyering  <address@hidden>
            Bruno Haible  <address@hidden>

        frexp-nolibm, frexpl-nolibm tests: Fix bug introduced on 2012-03-03.
        * modules/frexp-nolibm-tests (Files): Add tests/test-frexp.h,
        tests/randomd.c.
        (Makefile.am): Add randomd.c to test_frexp_nolibm_SOURCES.
        * modules/frexpl-nolibm-tests (Files): Add tests/test-frexp.h,
        tests/randoml.c.
        (Makefile.am): Add randoml.c to test_frexpl_nolibm_SOURCES.

diff --git a/modules/frexp-nolibm-tests b/modules/frexp-nolibm-tests
index 963a52e..39e8159 100644
--- a/modules/frexp-nolibm-tests
+++ b/modules/frexp-nolibm-tests
@@ -1,10 +1,12 @@
 Files:
 tests/test-frexp.c
+tests/test-frexp.h
 tests/minus-zero.h
 tests/infinity.h
 tests/nan.h
 tests/signature.h
 tests/macros.h
+tests/randomd.c
 
 Depends-on:
 isnand-nolibm
@@ -15,4 +17,4 @@ configure.ac:
 Makefile.am:
 TESTS += test-frexp-nolibm
 check_PROGRAMS += test-frexp-nolibm
-test_frexp_nolibm_SOURCES = test-frexp.c
+test_frexp_nolibm_SOURCES = test-frexp.c randomd.c
diff --git a/modules/frexpl-nolibm-tests b/modules/frexpl-nolibm-tests
index ffc6892..7f5d547 100644
--- a/modules/frexpl-nolibm-tests
+++ b/modules/frexpl-nolibm-tests
@@ -1,10 +1,12 @@
 Files:
 tests/test-frexpl.c
+tests/test-frexp.h
 tests/minus-zero.h
 tests/infinity.h
 tests/nan.h
 tests/signature.h
 tests/macros.h
+tests/randoml.c
 
 Depends-on:
 fpucw
@@ -16,4 +18,4 @@ configure.ac:
 Makefile.am:
 TESTS += test-frexpl-nolibm
 check_PROGRAMS += test-frexpl-nolibm
-test_frexpl_nolibm_SOURCES = test-frexpl.c
+test_frexpl_nolibm_SOURCES = test-frexpl.c randoml.c




reply via email to

[Prev in Thread] Current Thread [Next in Thread]