Re: [PATCH] frexp-nolibm-tests: include required test-frexp.h

[Jim Meyering]

Bruno Haible wrote:
> Hi Jim,
>
>> I tried to build coreutils using the latest from gnulib
>> and saw compilation failures in the new tests:
>>
>>   test-frexp.c:59:24: fatal error: test-frexp.h: No such file or directory
>>   compilation terminated.
>>   test-frexpl.c:66:24: fatal error: test-frexp.h: No such file or directory
>>   compilation terminated.
>
> Oops. Indeed, I can reproduce it with
>   $ ./gnulib-tool --test --with-tests frexp-nolibm
> and
>   $ ./gnulib-tool --test --with-tests frexpl-nolibm
>
>> * modules/frexp-nolibm-tests (Files): Add test-frexp.h, which
>> is included by test-frexp.c.
>> Also add tests/randomd.c, required due to test-frexp.h's use
>> of RANDOM.
>> (test_frexp_nolibm_SOURCES): Now that we're using
>> randomd/RANDOM, we must link with randomd.c.
>
> This is good and fixes half of the problem. I added the other half
> (module 'frexpl-nolibm-tests') and pushed it.

Thanks!

>>  2012-03-07  Jim Meyering  <address@hidden>
>>
>> +    frexp-nolibm-tests: include required test-frexp.h
>> +    * modules/frexp-nolibm-tests (Files): Add test-frexp.h, which
>> +    is included by test-frexp.c.
>> +    Also add tests/randomd.c, required due to test-frexp.h's use
>> +    of RANDOM.
>> +    (test_frexp_nolibm_SOURCES): Now that we're using
>> +
>
> One line of ChangeLog got lost. With 'vc-dwim --commit' this would not
> happen, I think?

I used vc-dwim --c for the first commit, which
simply added test-frexp.h to the Files list.

Then I edited the log via "g ci --amend -a" as
I realized more changes were needed.
Finally I manually sync'd the log back to the ChangeLog
file and did a final --amend.

It's that final step, to sync from commit log to ChangeLog
that would have to be automated, but I keep hoping you'll
agree to drop the ChangeLog.