[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Revised announce-gen patch
From: |
Eric Wong |
Subject: |
Re: Revised announce-gen patch |
Date: |
Wed, 21 Mar 2012 00:15:14 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
How about using the generic Digest module instead?
Something like this (totally untested) patch:
diff --git a/build-aux/announce-gen b/build-aux/announce-gen
index 3ca90a9..c453d44 100755
--- a/build-aux/announce-gen
+++ b/build-aux/announce-gen
@@ -29,8 +29,7 @@ my $VERSION = '2012-01-06 07:46'; # UTC
use strict;
use Getopt::Long;
-use Digest::MD5;
-use Digest::SHA1;
+use Digest;
use POSIX qw(strftime);
(my $ME = $0) =~ s|.*/||;
@@ -151,17 +150,14 @@ sub print_checksums (@)
print "Here are the MD5 and SHA1 checksums:\n";
print "\n";
- foreach my $meth (qw (md5 sha1))
+ foreach my $meth (qw (MD5 SHA-1))
{
foreach my $f (@file)
{
open IN, '<', $f
or die "$ME: $f: cannot open for reading: $!\n";
binmode IN;
- my $dig =
- ($meth eq 'md5'
- ? Digest::MD5->new->addfile(*IN)->hexdigest
- : Digest::SHA1->new->addfile(*IN)->hexdigest);
+ my $dig = Digest->new($meth)->addfile(*IN)->hexdigest;
close IN;
print "$dig $f\n";
}
--
Eric Wong