Re: should an empty "pkgdata_DATA" cause creation of $(pkgdatadir) by "make install"?

[Stefano Lattarini]

On 03/21/2012 11:14 PM, Bruno Haible wrote:
> Hi Stefano,
> 
>> We finally decided that the older behaviour was a bug.  We've thus fixed it
>> (in the automake maint branch, fix to appear in automake 1.11.4),
> 
> Cool! Many thanks for your considerations and perseverance.
> 
>> and I now propose the attached patch against gnulib-tool.  OK to push?
> 
>> +    # Automake versions < 1.11.3 create an empty pkgdatadir at
> 
> s/1.11.3/1.11.4/ (twice)
>
Oops, fixed.

>> +    # See automake bugs #10997 and #11030.
> 
> Please provide complete URLs for these bug reports.
>
Done.

> It is not trivial to look them up. At least I cannot find them in the bug
> tracker on Savannah [1].
>
Because they're not there :-) -- they're on the debbugs tracker:

 <http://debbugs.gnu.org/cgi/pkgreport.cgi?package=automake>

Once you know that, looking them up is very trivial (in the good sense); e.g.:

 <http://debbugs.gnu.org/10997>

> It apparently requires insider knowledge to know where to find them.
>
Not really; see:

 <http://www.gnu.org/software/automake/manual/automake.html#Reporting-Bugs>

(kudos to Ralf for writing that section of the manual).

> Otherwise OK to apply. Thanks!
> 
> Bruno
> 
> [1] http://savannah.gnu.org/bugs/?group=automake
>
(As a partial off-topic: is there any way to shut this down?  Since we don't
use the savannah tracker, allowing new issues to be opened there is only going
to be cause of confusion or duplication).

Patch pushed now.  Here is what I've squashed in:

-*-*-

diff --git a/gnulib-tool b/gnulib-tool
index fae325c..78ad5a5 100755
--- a/gnulib-tool
+++ b/gnulib-tool
@@ -3348,9 +3348,11 @@ func_emit_lib_Makefile_am ()
     echo "noinst_HEADERS ="
     echo "noinst_LIBRARIES ="
     echo "noinst_LTLIBRARIES ="
-    # Automake versions < 1.11.3 create an empty pkgdatadir at
+    # Automake versions < 1.11.4 create an empty pkgdatadir at
     # installation time if you specify pkgdata_DATA to empty.
-    # See automake bugs #10997 and #11030.
+    # See automake bugs #10997 and #11030:
+    #  * http://debbugs.gnu.org/10997
+    #  * http://debbugs.gnu.org/11030
     # So we need this workaround.
     if grep '^pkgdata_DATA *+=' "$tmp"/allsnippets > /dev/null; then
       echo "pkgdata_DATA ="
@@ -3671,9 +3673,11 @@ func_emit_tests_Makefile_am ()
       echo "check_LIBRARIES = libtests.a"
     fi
   fi
-  # Automake versions < 1.11.3 create an empty pkgdatadir at
+  # Automake versions < 1.11.4 create an empty pkgdatadir at
   # installation time if you specify pkgdata_DATA to empty.
-  # See automake bugs #10997 and #11030.
+  # See automake bugs #10997 and #11030:
+  #  * http://debbugs.gnu.org/10997
+  #  * http://debbugs.gnu.org/11030
   # So we need this workaround.
   if grep '^pkgdata_DATA *+=' "$tmp"/main_snippets "$tmp"/longrunning_snippets 
> /dev/null; then
     echo "pkgdata_DATA ="

-*-*-

Thanks,
 Stefano