bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: warnings.m4: check the compiler, not the preprocessor.


From: Akim Demaille
Subject: Re: warnings.m4: check the compiler, not the preprocessor.
Date: Fri, 30 Mar 2012 09:49:09 +0200

Hi Bruno!

Le 30 mars 2012 à 03:26, Bruno Haible a écrit :

> Akim Demaille wrote:
>> Currently the macro does
>> not depend on the language to store its result
> 
> This patch appears broken to me:
>  - On one hand it augments CPPFLAGS without ever setting it back.
>  - On the other hand it saves and restores CFLAGS or CXXFLAGS but
>    without temporarily modifying its value.
> 
> Can you please provide a fix? Gnulib macros should in general *not*
> have lasting effects on $CPPFLAGS, $CFLAGS, $CXXFLAGS.

Of course, I'm sorry for this error :/

Attachment: 0001-warnings.m4-fix-errors.patch
Description: Binary data

Attachment: 0002-warnings.m4-exhibit-an-if-else-interface.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]