[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add const qualifier for charset_name in init_dfa
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH] Add const qualifier for charset_name in init_dfa |
|
Date: |
Sat, 31 Mar 2012 00:15:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120327 Icedove/10.0.3 |
On 26.03.2012 03:24, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> In GRUB charset is hardwired to UTF-8 and we return just a pointer to
> "UTF-8" in nl_langinfo (CODESET);
> I propose adding const qualifier since this function already handles
> codeset_name as a pointer to const string.
Any problem with this patch?
> === modified file 'grub-core/gnulib/regcomp.c'
> --- grub-core/gnulib/regcomp.c 2012-03-26 00:45:46 +0000
> +++ grub-core/gnulib/regcomp.c 2012-03-26 01:08:18 +0000
> @@ -853,7 +849,7 @@ init_dfa (re_dfa_t *dfa, size_t pat_len)
> {
> __re_size_t table_size;
> #ifndef _LIBC
> - char *codeset_name;
> + const char *codeset_name;
> #endif
> #ifdef RE_ENABLE_I18N
> size_t max_i18n_object_size = MAX (sizeof (wchar_t), sizeof (wctype_t));
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature