Re: ioctl.c

[Nikos Mavrogiannopoulos]

On 04/10/2012 08:07 PM, Eric Blake wrote:


> From whom?  We should credit the correct author before applying anything
> (at least it is small enough to be trivial and not require copyright
> assignment).

I forward you the original e-mail.

regards,
Nikos

-------- Original Message --------
Subject: Re: [W32] gnutls-2.12.18 fixes
Date: Tue, 10 Apr 2012 00:45:58 +0400
From: LRN <address@hidden>
To: address@hidden

On 09.04.2012 19:55, Nikos Mavrogiannopoulos wrote:

> On 04/09/2012 04:13 PM, LRN wrote:
>
>>>> W32 support in GNUTLS 2.x deteriorated a little bit since my
>>>> last patching session. Here's a few things that require
>>>> fixing: 1) gnutls-2.12.18/lib/nettle/egd.* is incompatible
>>>> with W32 (uses UNIX domain sockets, absolute UNIX-style
>>>> paths, calls stat() on integer file descriptors thought to be
>>>> sockets, and uses S_IFSOCK). It should be disabled at
>>>> configure time. 2) gnutls-2.12.18/lib/nettle/rnd.c requires
>>>> #include <wincrypt.h> on W32
>>> Hello, Do these issues occur in gnutls 3.0.18?
>> No idea, haven't tried 3.x yet (should i?).
>
>
> I'd suggest yes, because 3.0 is the current stable branch. The
> 2.12.x is pretty much end of life.
>


libopts depends on libintl on W32, but -lintl is not added to its
dependencies.
The attached patch is W32-only, because it adds -lintl
unconditionally. I can get away with that, but you'll probably need to
set some variable to "-lintl" in configure, AC_SUBST() it, and use it
to set libopts_la_LIBADD in src/libopts/Makefile.am

Other than that, everything is fine - all enabled tests pass.
gl tests fail to compile, but after patching (i've attached the patch)
they all pass too.

signature.asc
Description: OpenPGP digital signature