Re: cross-compilation guesses (2)

[Jim Meyering]

Bruno Haible wrote:
>>   2) On glibc systems, which are often used as cross-compilation targets
>>      (think of embedded systems (routers, map navigation devices, etc.)),
>>      the cross-compilation guesses should better be correct. I.e. when
>>      no problem is known on glibc systems or Linux, the result should be
>>      "guessing yes".
>
> This proposed patch addresses many of these cases where we previously
> did a "guessing no" even on glibc systems. The idiom is the same throughout
> this patch.
>
> Jim, Eric, this patch touches many of your modules. OK to apply?
>
>
> 2012-05-01  Bruno Haible  <address@hidden>
>
>       Avoid "guessing no" guesses when cross-compiling to glibc systems.
...

> --- m4/remove.m4.orig Tue May  1 22:10:17 2012
> +++ m4/remove.m4      Tue May  1 21:02:11 2012
> @@ -1,4 +1,4 @@
> -# remove.m4 serial 3
> +# remove.m4 serial 4
>  dnl Copyright (C) 2009-2012 Free Software Foundation, Inc.
>  dnl This file is free software; the Free Software Foundation
>  dnl gives unlimited permission to copy and/or distribute it,
> @@ -10,7 +10,16 @@
>    AC_REQUIRE([gl_STDIO_H_DEFAULTS])
>    AC_REQUIRE([gl_FUNC_RMDIR])
>    AC_REQUIRE([gl_FUNC_UNLINK])
> -  if test "$gl_cv_func_rmdir_works:$gl_cv_func_unlink_works" != yes:yes; then
> +  if { case "$gl_cv_func_rmdir_works" in
> +         *yes) false;;
> +         *) true;;
> +       esac
> +     } \
> +     || { case "$gl_cv_func_unlink_works" in
> +            *yes) false;;
> +            *) true;;
> +          esac
> +        }; then

Hi Bruno,
That all looks fine.
Did you consider this approach?
I find it more concise/readable than the above:

  if { case "$gl_cv_func_rmdir_works:$gl_cv_func_unlink_works" in
         *yes:*yes) false;;
         *) true;;
       esac
     }; then