Re: new module 'system-quote'

[Bruno Haible]

Eli,

> > If I recall it correctly, the
> >   check_one (interpreter, prog, "*");
> > case failed: Apparently, when you pass a single unquoted '*' argument
> > to CreateProcess, it can fail with GetLastError() = ERROR_PATH_NOT_FOUND.
> 
> That is expected and reasonable: the first token in the argument is
> the executable to invoke, so it cannot possibly include wildcards.

There's a misunderstanding. I know that the CreateProcess() does less
processing on the first token than on the remaining ones (the arguments),
therefore the code is made for the arguments, and the unit test also
tests the arguments.

If you want to see what happens, just remove the '*' from
SHELL_SPECIAL_CHARS and re-run the unit test.

> Btw, "make check" seems to become stuck close to forever in the
> "test_rwlock" stage; I lost patience and interrupted it.  Is that
> normal?

The 'lock' test is slow on some platforms. Just let it run. As long as
it does not produce a dialog or "ps" does not show it as stuck, it is
running.

> > The test-system-quote.sh script should be run through bash. It doesn't
> > matter how this bash is invoked.

But the script refers to ${EXEEXT}, therefore you need to set EXEEXT=.exe
if you run the script separately, not through "make check".

Bruno