bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Comparing binary files with Diff 3.2 compiled with MinGW


From: Eli Zaretskii
Subject: Re: Comparing binary files with Diff 3.2 compiled with MinGW
Date: Mon, 14 May 2012 19:02:57 +0300

> Date: Sun, 13 May 2012 19:37:33 -0700
> From: Paul Eggert <address@hidden>
> CC: address@hidden, address@hidden
> 
> Thanks for the diffutils patch.  We're a bit better off with something
> even closer to the pre-2006 approach, which took care to convert
> size_t to off_t before negating it, as that is important on hosts where
> sizeof (size_t) < sizeof (off_t).  Also, it's cleaner to use set_binary_mode
> uniformly rather than set_binary_mode sometimes and SET_BINARY others.
> Here's a revised patch that I hope catches all the issues.  I plan to
> push it after Bruno's binary-io.h patches are pushed.

Works for me, thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]