bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint.mk: fix VPATH issues


From: Jim Meyering
Subject: Re: [PATCH] maint.mk: fix VPATH issues
Date: Thu, 07 Jun 2012 18:10:10 +0200

Akim Demaille wrote:
> My announcements for Bison referred to ../../NEWS :)
>
> The interface is "backward-compatible", so you should
> pass
>
>       --srcdir=. --news=./NEWS
>
> (i.e., the call to --news remains the same).  But _if_
> breaking backward compatibility, under the assumption that
> no one calls announcement-gen by hand, by only via the
> Makefile target, then I would prefer
>
>       --srcdir=. --news=NEWS
>
> (and, gosh, I hate ChangeLogs)
>
> From edc63474c0851715f866cf14f275903529d19ec7 Mon Sep 17 00:00:00 2001
> From: Akim Demaille <address@hidden>
> Date: Thu, 7 Jun 2012 17:15:59 +0200
> Subject: [PATCH] announce-gen: VPATH issues
>
> * build-aux/announce-gen (--srcdir): New option, used to trim the
> $srcdir part of the path from $builddir to NEWS.
> * top/maint.mk (announcement): Adjust.
> ---
>  ChangeLog              |    7 +++++++
>  build-aux/announce-gen |   11 +++++++----
>  top/maint.mk           |    1 +
>  3 files changed, 15 insertions(+), 4 deletions(-)
...

Looks fine.  One suggested addition:

> @@ -67,7 +68,8 @@ These options must be specified:
>
>  The following are optional:
>
> -   --news=NEWS_FILE
> +   --news=NEWS_FILE             accumulates

Telling how to use it, good!
How about saying what it is, too?

      --news=NEWS_FILE             name of news file (accumulates)

> +   --srcdir=DIR                 where to find the NEWS_FILEs (default: 
> $srcdir)
>     --bootstrap-tools=TOOL_LIST  a comma-separated list of tools, e.g.,
>                                  autoconf,automake,bison,gnulib
>     --gnulib-version=VERSION     report VERSION as the gnulib version, where
> @@ -182,7 +184,7 @@ sub print_news_deltas ($$$)
>    my ($news_file, $prev_version, $curr_version) = @_;
>
>    my $news_name = $news_file;
> -  $news_name =~ s|^\./||;
> +  $news_name =~ s|^\Q$srcdir\E/||;
>
>    print "\n$news_name\n\n";
...



reply via email to

[Prev in Thread] Current Thread [Next in Thread]