bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

ttyname_r on OSF/1


From: Bruno Haible
Subject: ttyname_r on OSF/1
Date: Sun, 24 Jun 2012 23:09:29 +0200
User-agent: KMail/4.7.4 (Linux/3.1.10-1.9-desktop; KDE/4.7.4; x86_64; ; )

On OSF/1, I'm seeing this test failure in an *interactive* "make check" of
a ptsname_r testdir:

  test-ptsname_r.c:193: assertion failed
  FAIL: test-ptsname_r

It turns out the cause is a bug in gnulib's ttyname_r: It fails to add a
trailing NUL byte to the output string. This fixes it.


2012-06-24  Bruno Haible  <address@hidden>

        ttyname_r: Fix result on OSF/1, Solaris.
        * lib/ttyname_r.c (ttyname_r): Produce a NUL-terminated result.

--- lib/ttyname_r.c.orig        Sun Jun 24 22:37:31 2012
+++ lib/ttyname_r.c     Sun Jun 24 22:33:15 2012
@@ -45,7 +45,7 @@
     return err;
   if (buflen < sizeof (largerbuf))
     {
-      size_t namelen = strlen (largerbuf);
+      size_t namelen = strlen (largerbuf) + 1;
       if (namelen > buflen)
         return ERANGE;
       memcpy (buf, largerbuf, namelen);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]