Re: FYI: do-release-commit-and-tag: fix typo

[Akim Demaille]

Le 5 juil. 2012 à 16:53, Jim Meyering a écrit :

> This script doesn't use set -e.
> I'd say that having to limit such use of "&&" is a good reason
> not to use "set -e".

In my experience, not setting set -e is asking for troubles.
I have been bitten way too often because of failures that go
unnoticed, and the script just continues.

All the errors should be checked, definitely yes.  Yet,
it is easy to forget to check something (or someone else
didn't), and that's where set -e saves the day.  Well,
maybe not the day, but hours.

>> * build-aux/do-release-commit-and-tag: Actually the test was right,
>> but the error message was wrong.
> 
> As far as I can tell, the message is not wrong.

You are right, I changed to this:

    do-release-commit-and-tag: fix the previous commit
    
    * build-aux/do-release-commit-and-tag: Actually the test was right,
    but the comment and the error message were misleading.
    Fix comment, and improve error message.
    Perform check first, so that NEWS is not modified uselessly.

> ACK with those changes.

Done, thanks!