Re: [PATCH] maint: enable the sc_avoid_if_before_free syntax-check

[Bruno Haible]

Hi Jim,

> Bruno, is it ok to remove the one in lib/clean-temp.c, below?

No, it's better if the 'if (old_array != NULL)' stays there. It reminds
the maintainer of the code of the two possible cases.

So, can you please add clean-temp.c to if_before_free_offenders_ ?

Note also that this "avoid if before free" rule is less valuable nowadays
than a couple of years ago: It was a migration aid from K&R C to ANSI C.
Nowadays little code remains that is written for K&R C, and few minds program
for K&R C. Therefore the "if before free" cases that are remaining are
more likely to be intentional than before.

Bruno