Re: [PATCH] maint.mk: new syntax check for HAVE_DECL checks

[Jim Meyering]

Bruno Haible wrote:

> Eric Blake wrote:
>> Should we get rid of the
>> sanity checks that use #error when a macro is undefined, in order
>> to reduce the number of exemptions?
>
> I agree, this would be useful for those source files that are always
> taken as an entire module from gnulib. I wouldn't do so for error.c and
> getopt.c, though: these two files are shared with many more packages,
> through manual copying. Also strtoimax.c is a bit complicated (because
> shared among two modules), therefore the check is non-trivial and welcome.
>
> Here are 2 proposed patch. Jim, Simon, OK?
>
>
> 2012-07-15  Bruno Haible  <address@hidden>
>
>       getpass: Assume AC_CHECK_DECLS_ONCE invocation, like in getpass.m4.
>       * lib/getpass.h: Assume HAVE_DECL_GETPASS is defined.
>       * cfg.mk 
> (exclude_file_name_regexp--sc_prohibit_defined_have_decl_tests):
>       Remove exemption for getpass.h.
>       Suggested by Eric Blake.
...
> 2012-07-15  Bruno Haible  <address@hidden>
>
>       fpending: Assume AC_CHECK_DECLS_ONCE invocation, like in fpending.m4.
>       * lib/fpending.h: Assume HAVE_DECL___FPENDING is defined.
>       * cfg.mk 
> (exclude_file_name_regexp--sc_prohibit_defined_have_decl_tests):
>       Remove exemption for fpending.h.
>       Suggested by Eric Blake.

Thanks, Bruno.
Both look fine.