Re: [PATCH] gitlog-to-changelog: VPATH build issues.

[Eric Blake]

On 07/15/2012 11:56 AM, Jim Meyering wrote:
> Akim Demaille wrote:
> 
>> Le 15 juil. 2012 à 16:48, Akim Demaille a écrit :
>>
>>> This patch should help people who, like me, sometimes build
>>> from /tmp for instance, while the sources are in /home.
>>
>>> +   --git-dir=DIR set the path to the Git repository.
>>
>> Actually, I hesitated between --git-dir and --srcdir.  Whatever
>> you prefer.
> 
> THe patch looks fine.  You're welcome to push.
> I too am ambivalent about the name.  Either is ok with me.

I prefer --srcdir, if only because we already switched from CVS to git,
and might in the future switch from git to $shiny_new_vcs.  Tying the
VCS name to the option means one more place to swap in that theoretical
future.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature