Re: test-getlogin_r is annoyingly random

[Jim Meyering]

Richard W.M. Jones wrote:

> When building in Koji (the Fedora build system), the test is usually
> skipped:
>
>   Skipping test: stdin is not a tty.
>   SKIP: test-getlogin_r
>
> except when it doesn't skip and instead it fails:
>
>   test-getlogin_r.c:62: assertion failed
>   /bin/sh: line 5: 11074 Aborted EXEEXT='' srcdir='.'
> LOCALE_FR='fr_FR' LOCALE_FR_UTF8='fr_FR.UTF-8' LOCALE_FR='fr_FR'
> LOCALE_TR_UTF8='tr_TR.UTF-8' LOCALE_FR='fr_FR'
> LOCALE_FR_UTF8='fr_FR.UTF-8' LOCALE_JA='ja_JP'
> LOCALE_ZH_CN='zh_CN.GB18030' LOCALE_FR_UTF8='fr_FR.UTF-8'
> LOCALE_FR='fr_FR' LOCALE_FR_UTF8='fr_FR.UTF-8' LOCALE_JA='ja_JP'
> LOCALE_ZH_CN='zh_CN.GB18030' LOCALE_FR='fr_FR'
> LOCALE_FR_UTF8='fr_FR.UTF-8' LOCALE_JA='ja_JP'
> LOCALE_ZH_CN='zh_CN.GB18030'
> abs_aux_dir='/builddir/build/BUILD/libguestfs-1.19.21/build-aux'
> MAKE='make' LOCALE_FR='fr_FR' LOCALE_FR_UTF8='fr_FR.UTF-8'
> LOCALE_JA='ja_JP' LOCALE_ZH_CN='zh_CN.GB18030' ${dir}$tst
>   FAIL: test-getlogin_r
>
> It fails rarely, but often enough to be annoying.  I can't see
> anything stochastic about the test.  I'm guessing a race that is
> somehow affected by the load on the build system machine.
>
> FWIW $LOGNAME and $USER are both set to 'mockbuild'.
>
> On a local machine the test runs and succeeds.
>
> Actually we don't even use this module (it's pulled in as a dependency
> of something) and would prefer a way to disable tests selectively,
> eg. by setting a SKIP_GETLOGIN_R_TEST=1 environment variable or
> similar.

Hi Rich,

A quick workaround is to use gnulib's --avoid option
to tell it you don't want the getlogin_r tests:

    --avoid=getlogin_r-tests