Re: [PATCH 1/2] gnu-web-doc-update: check the requirements.

[Akim Demaille]

Le 19 juil. 2012 à 16:11, Jim Meyering a écrit :

> TL;DR:  ACK (with comments documenting find_tool duplication) ;-)

OK, thanks for the review!  Installed both, with this one
patched as follows.

diff --git a/ChangeLog b/ChangeLog
index 40ada21..1494ef2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -6,6 +6,7 @@
        gnu-web-doc-update: check the requirements.
        * build-aux/gnu-web-doc-update (find_tool): Import from bootstrap.
        ($CVS, $CVSU, $GIT, $RSYNC, $XARGS): New.
+       * build-aux/bootstrap (find_tool): Comment change.
 
 2012-07-17  Akim Demaille  <address@hidden>
 
diff --git a/build-aux/bootstrap b/build-aux/bootstrap
index e00c8bbb..e3e270b 100755
--- a/build-aux/bootstrap
+++ b/build-aux/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2012-07-10.09; # UTC
+scriptversion=2012-07-19.14; # UTC
 
 # Bootstrap this package from checked-out sources.
 
@@ -214,6 +214,8 @@ use_git=true
 # otherwise find the first of the NAMES that can be run (i.e.,
 # supports --version).  If found, set ENVVAR to the program name,
 # die otherwise.
+#
+# FIXME: code duplication, see also gnu-web-doc-update.
 find_tool ()
 {
   find_tool_envvar=$1
diff --git a/build-aux/gnu-web-doc-update b/build-aux/gnu-web-doc-update
index 36a3e51..263a8f1 100755
--- a/build-aux/gnu-web-doc-update
+++ b/build-aux/gnu-web-doc-update
@@ -67,6 +67,8 @@ EOF
 # otherwise find the first of the NAMES that can be run (i.e.,
 # supports --version).  If found, set ENVVAR to the program name,
 # die otherwise.
+#
+# FIXME: code duplication, see also bootstrap.
 find_tool ()
 {
   find_tool_envvar=$1