[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] maint.mk: use silent-rules support from Automake
From: |
Jim Meyering |
Subject: |
Re: [PATCH 4/4] maint.mk: use silent-rules support from Automake |
Date: |
Mon, 30 Jul 2012 14:25:27 +0200 |
Akim Demaille wrote:
> * top/maint.mk (news-check, vc-diff-check, announcement)
> (no-submodule-changes, alpha beta stable, release-prep)
> (web-manual, update-copyright): Use $(AM_V_GEN) and $(AM_V_at).
ACK modulo a consistency nit:
> diff --git a/top/maint.mk b/top/maint.mk
> index fe14a80..37c7767 100644
> --- a/top/maint.mk
> +++ b/top/maint.mk
...
> @@ -1321,7 +1321,7 @@ endef
>
> .PHONY: no-submodule-changes
> no-submodule-changes:
> - if test -d $(srcdir)/.git; then \
> + $(AM_V_GEN)if test -d $(srcdir)/.git; then \
> diff=$$(cd $(srcdir) && git submodule -q foreach \
> git diff-index --name-only HEAD) \
> || exit 1; \
> @@ -1360,16 +1360,16 @@ check: $(gl_public_submodule_commit)
> .PHONY: alpha beta stable
> ALL_RECURSIVE_TARGETS += alpha beta stable
> alpha beta stable: $(local-check) writable-files $(submodule-checks)
> - test $@ = stable \
> + $(AM_V_GEN) test $@ = stable \
For consistency with other uses, don't add a space after $(AM_V_GEN).
- [PATCH 0/4] maint.top: simplify release procedure, Akim Demaille, 2012/07/30
- [PATCH 3/4] maint.mk: provide a web-manual-update target, Akim Demaille, 2012/07/30
- [PATCH 1/4] gnu-web-doc-update: fix --help, Akim Demaille, 2012/07/30
- [PATCH 4/4] maint.mk: use silent-rules support from Automake, Akim Demaille, 2012/07/30
- Re: [PATCH 4/4] maint.mk: use silent-rules support from Automake,
Jim Meyering <=
- Re: [PATCH 0/4] maint.top: simplify release procedure, Jim Meyering, 2012/07/30