bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: maint.mk: a "release-commit" wrapper to do-release-commit-and-tag


From: Jim Meyering
Subject: Re: maint.mk: a "release-commit" wrapper to do-release-commit-and-tag
Date: Wed, 01 Aug 2012 11:41:53 +0200

Akim Demaille wrote:
> Le 1 août 2012 à 10:59, Bruno Haible a écrit :
>
>> Akim Demaille wrote:
>>> I used […] for default values, by habit (e.g., ./configure),
>>> but I can restore to (default: …) if you prefer.
>>
>> This notation […] is not widespread enough, IMO, that people would
>> immediately understand it. Especially if the value is just '.':
>>
>>  -C, --builddir=DIR   location of (configured) Makefile [.]
>>
>> I find this shortened output confusing.

Thanks.  I think the explicit "default: ..." is better, too.

> OK.  configure includes a
>
>   Defaults for the options are specified in brackets.
>
> but here is a version with (default: …).  Since we are dangerously
> close to 80 columns, I have requisitioned a space between options
> and help message.
>
> commit bd54a45e6e4bcb3ee7359c9b4f1d831a6291148f
> Author: Akim Demaille <address@hidden>
> Date:   Wed Aug 1 09:55:49 2012 +0200
>
>     maint.mk: a "release-commit" wrapper to do-release-commit-and-tag
>
>     * build-aux/do-release-commit-and-tag: Move variable definitions
>     together.
>     ($branch): Instead of defaulting to "master", default to the current
>     branch (as gnu-web-doc-update does).
>     (help): Display the current values of the option arguments.
>     * top/maint.mk (release-commit): New.
>     * top/README-release: Simplify the corresponding step.

This all looks fine.
I'm glad to see complexity moving from README-release into maint.mk, e.g.,

  > -    build-aux/do-release-commit-and-tag --branch=maint -C _build X.Y.Z 
stable
  > +    make release-commit RELEASE='X.Y stable'

ACK



reply via email to

[Prev in Thread] Current Thread [Next in Thread]