bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

maintainer-makefile: quoting


From: Simon Josefsson
Subject: maintainer-makefile: quoting
Date: Tue, 07 Aug 2012 08:28:13 +0200
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/23.3 (gnu/linux)

I got this error from syntax-check:

address@hidden:~/src/libidn$ make sc_vulnerable_makefile_CVE-2012-3386
vulnerable_makefile_CVE-2012-3386
/bin/sh: 2: Syntax error: "(" unexpected
make: *** [sc_vulnerable_makefile_CVE-2012-3386] Fel 2
address@hidden:~/src/libidn$ 

The patch below appears to fix it.  This is on a system with dash as
/bin/sh.  Thoughts?

/Simon

diff --git a/ChangeLog b/ChangeLog
index 774cdb1..0485168 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2012-08-07  Simon Josefsson  <address@hidden>
+
+       * top/maint.mk (sc_vulnerable_makefile_CVE-2009-4029): Quote arguments.
+       (sc_vulnerable_makefile_CVE-2012-3386): Likewise.
+
 2012-08-05  Jim Meyering  <address@hidden>
 
        extern-inline: also ignore -Wmissing-declarations
diff --git a/top/maint.mk b/top/maint.mk
index f42c199..d948a47 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1222,7 +1222,7 @@ sc_prohibit_path_max_allocation:
 
 sc_vulnerable_makefile_CVE-2009-4029:
        @prohibit='perm -777 -exec chmod a\+rwx|chmod 777 \$$\(distdir\)' \
-       in_files=(^\|/)Makefile\\.in$$                                  \
+       in_files='(^\|/)Makefile\\.in$$'                                \
        halt=$$(printf '%s\n'                                           \
          'the above files are vulnerable; beware of running'           \
          '  "make dist*" rules, and upgrade to fixed automake'         \
@@ -1231,7 +1231,7 @@ sc_vulnerable_makefile_CVE-2009-4029:
 
 sc_vulnerable_makefile_CVE-2012-3386:
        @prohibit='chmod a\+w \$$\(distdir\)'                           \
-       in_files=(^\|/)Makefile\\.in$$                                  \
+       in_files='(^\|/)Makefile\\.in$$'                                \
        halt=$$(printf '%s\n'                                           \
          'the above files are vulnerable; beware of running'           \
          '  "make distcheck", and upgrade to fixed automake'           \



reply via email to

[Prev in Thread] Current Thread [Next in Thread]