bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib-comp.m4 indentation


From: Bruno Haible
Subject: Re: gnulib-comp.m4 indentation
Date: Wed, 15 Aug 2012 01:30:38 +0200
User-agent: KMail/4.7.4 (Linux/3.1.10-1.9-desktop; KDE/4.7.4; x86_64; ; )

Hello Dmitriy,

> it seems I've found another very small bug inside gnulib-tool. See line 3920 
> of emit_autoconf_snippet: it will never do the right indentation (which we 
> need e.g. in emit_autoconf_snippets) since $indentation is always empty. We 
> just need to add one line in the beginning of emit_autoconf_snippet:
> 
> indentation=$1

You're entirely right again. Fixed like you suggested:


2012-08-14  Bruno Haible  <address@hidden>

        gnulib-tool: Fix indentation of generated gnulib-comp.m4 file.
        * gnulib-tool (func_emit_autoconf_snippet): Initialize indentation
        from argument.
        Reported and fix suggested by Dmitriy Selyutin <address@hidden>.

--- gnulib-tool.orig    Wed Aug 15 01:28:53 2012
+++ gnulib-tool Wed Aug 15 01:26:50 2012
@@ -3892,6 +3892,7 @@
 # func_emit_autoconf_snippet indentation
 # emits the autoconf snippet of a module.
 # Input:
+# - indentation       spaces to prepend on each line
 # - local_gnulib_dir  from --local-dir
 # - modcache          true or false, from --cache-modules/--no-cache-modules
 # - sed_replace_build_aux  sed expression that replaces reference to build-aux
@@ -3905,9 +3906,9 @@
 #                     command line options.
 # - disable_gettext   true or false. It tells whether to disable AM_GNU_GETTEXT
 #                     invocations.
-# - indentation       spaces to prepend on each line
 func_emit_autoconf_snippet ()
 {
+  indentation="$1"
   if { case $module in
          gnumakefile | maintainer-makefile)
            # These modules are meant to be used only in the top-level 
directory.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]