bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 3/4] maint.mk: sc_prohibit_path_max_allocation: don't FP for UNIX


From: Jim Meyering
Subject: [PATCH 3/4] maint.mk: sc_prohibit_path_max_allocation: don't FP for UNIX_PATH_MAX
Date: Tue, 18 Sep 2012 09:00:11 +0200

From: Jim Meyering <address@hidden>

* top/maint.mk (sc_prohibit_path_max_allocation): Avoid false-positive
match for symbols like UNIX_PATH_MAX. Reported by Richard W.M. Jones
in http://thread.gmane.org/gmane.comp.emulators.guestfs/1902
---
 ChangeLog    | 7 +++++++
 top/maint.mk | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index ce15e28..eeea310 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2012-09-17  Jim Meyering  <address@hidden>

+       maint.mk: sc_prohibit_path_max_allocation: don't FP for UNIX_PATH_MAX
+       * top/maint.mk (sc_prohibit_path_max_allocation): Avoid false-positive
+       match for symbols like UNIX_PATH_MAX. Reported by Richard W.M. Jones
+       in http://thread.gmane.org/gmane.comp.emulators.guestfs/1902
+
+2012-09-17  Jim Meyering  <address@hidden>
+
        maint.mk: teach sc_prohibit_magic_number_exit to accept 77
        * top/maint.mk (sc_prohibit_magic_number_exit): Do not complain about
        uses like "exit (77)".  "77" is automake's "skip this test" exit code.
diff --git a/top/maint.mk b/top/maint.mk
index 9c660a1..f77d0c1 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1216,7 +1216,7 @@ sc_Wundef_boolean:
 # not be constant, or might overflow a stack.  In general, use PATH_MAX as
 # a limit, not an array or alloca size.
 sc_prohibit_path_max_allocation:
-       @prohibit='(\balloca *\([^)]*|\[[^]]*)PATH_MAX'                 \
+       @prohibit='(\balloca *\([^)]*|\[[^]]*)\bPATH_MAX'               \
        halt='Avoid stack allocations of size PATH_MAX'                 \
          $(_sc_search_regexp)

-- 
1.7.12.503.g5976753




reply via email to

[Prev in Thread] Current Thread [Next in Thread]