Re: Problem with new release target in maint.mk

[Jim Meyering]

Reuben Thomas wrote:
> On 1 October 2012 20:37, Jim Meyering <address@hidden> wrote:
>> Reuben Thomas wrote:
>>> I get the following error while trying to make a GNU Zile release:
>>>
>>> /bin/bash: -c: line 1: syntax error near unexpected token `then'
>>> /bin/bash: -c: line 1: address@hidden test -d ../release; then  \'
>>> make[2]: *** [release-prep] Error 1
>>>
>>> I'm using bash 4.2.24(1)-release as shipped with Ubuntu 12.04. /bin/sh
>>> is dash 0.5.7. (I am slightly unclear why the error above is from
>>> bash, not dash…)
>>
>> Hi Reuben,
>>
>> Are you sure you're using the latest?
>
> $ cd gnulib
> /home/rrt/Software/zile-stable/gnulib
> $ git pull
> Already up-to-date.
>
>> For the record, now that rule starts like this:
>>
>> .PHONY: release-prep
>> release-prep:
>>         $(AM_V_GEN)$(MAKE) --no-print-directory -s announcement \
>>           > ~/announce-$(my_distdir)
>>         $(AM_V_at)if test -d $(release_archive_dir); then       \
>>           ln $(rel-files) $(release_archive_dir);               \
>>           chmod a-w $(rel-files);                               \
>>         fi
>
> I don't think it can be that, because that's not line 1. I think it's
> the rule for writable-files:

Glad you solved the problem and that it's not with any version in git.
For future reference, the "*** [release-prep]" part of the diagnostic
you included above says that "release-prep" is the rule that failed.

> writable-files:
>       $(AM_V_GEN)if test -d $(release_archive_dir); then              \
>         for file in $(DIST_ARCHIVES); do                              \
>           for p in ./ $(release_archive_dir)/; do                     \