bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: update-copyright copyright notice corruption bug


From: Eric Blake
Subject: Re: update-copyright copyright notice corruption bug
Date: Wed, 02 Jan 2013 13:27:15 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0

On 01/02/2013 12:31 PM, Joseph S. Myers wrote:
> A second check of the automatic copyright updates for glibc showed that 
> update-copyright had corrupted some of the copyright notices.  I've 
> applied this glibc patch to fix that corruption.  bug-gnulib: see 
> attachment for a testcase.  Run update-copyright as:
> 
> UPDATE_COPYRIGHT_FORCE=1 UPDATE_COPYRIGHT_USE_INTERVALS=2 
> UPDATE_COPYRIGHT_MAX_LINE_LENGTH=79 update-copyright ctty-input.c

Thanks for the report. In particular, the culprit line that caused the
corruptions is important to understand:

> +++ b/hurd/ctty-output.c
> @@ -1,5 +1,5 @@
>  /* _hurd_ctty_output -- Do an output RPC and generate SIGTTOU if necessary.
> -   Copyright (C) 11999, 20135, 1997-1999 Free Software Foundation, Inc.
> +   Copyright (C) 1995-2013 Free Software Foundation, Inc.

The original was:

   Copyright (C) 1995,97,99 Free Software Foundation, Inc.

and that pattern (4-digits followed by 2-digits, with gaps in the years,
but no spaces in the listing) is not currently tested in the
update-copyright testsuite.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]