Re: [Patch] fix include for SIZE_MAX with Bionic libc

[Eric Blake]

On 01/15/2013 08:16 AM, Andoni Morales wrote:
> Hi,
> 
> Attached patch to fix the build with the Android NDK for x86. This was
> triggered building libtasn1 with the following error:
> 

> read-file.c: In function 'fread_file':
> read-file.c:62:17: error: 'SIZE_MAX' undeclared (first use in this function)
> read-file.c:62:17: note: each undeclared identifier is reported only
> once for each function it appears in

Thanks for the report.  However, your patch is not quite right for the
gnulib spirit, which is that we want our replacement <stdint.h> to work
around the bug in the Android headers so that ALL .c files can use
SIZE_MAX as specified by the standard, rather than having to chase down
each and every .c file (like read-file.c) and patch them individually.

I also wonder if your problem would be resolved by this alternate
proposed patch:
http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/32363

Meanwhile, can you please raise a bug report against the Android NDK to
get them to fix their headers to be standards-compliant?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature